Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 09-localhost client state implementation #3034

Closed
14 of 17 tasks
damiannolan opened this issue Jan 20, 2023 · 0 comments · Fixed by #3229
Closed
14 of 17 tasks

Add 09-localhost client state implementation #3034

damiannolan opened this issue Jan 20, 2023 · 0 comments · Fixed by #3229
Labels
02-client 09-localhost core epic type: feature New features, sub-features or integrations
Milestone
v7.1.0

Comments

@damiannolan
Copy link
Member

damiannolan commented Jan 20, 2023 •
edited
Loading

Summary

Based on the work in #2700, add a new client state implementation for 09-localhost.
The localhost client should be accompanied by a sentinel localhost connectionEnd which should be stored in state upon InitGenesis or enabed via a chain upgrade migration handler.

Update the 09-localhost client in #2700 to conform to the latest ClientState implementation in ibc-go/v7. A feature branch has been created here.

The body of work is detailed in the following issues:

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the v7.1.0 milestone Jan 20, 2023
@crodriguezvega crodriguezvega mentioned this issue Jan 26, 2023
Closed
9 tasks
This was referenced Feb 2, 2023
Closed
Merged
Merged
@damiannolan damiannolan added type: feature New features, sub-features or integrations epic labels Feb 20, 2023
@damiannolan damiannolan mentioned this issue Mar 2, 2023
Merged
9 tasks
chatton pushed a commit that referenced this issue Mar 8, 2023
@damiannolan
Adding 09-localhost loopback client module (#3229)
d840c69 
feat: adding 09-localhost loopback client module [\#3034](#3034). Please see the 09-localhost documentation [here](https://ibc.cosmos.network/main/ibc/light-clients/localhost/overview.html).
feat: AllowedClients on-chain param allows chains to pause usage of specific client types by removing the client type from the param.
imp: Update all channel events to use `connection_id` attribute. The `packet_connection` attribute has been deprecated.
mergify bot pushed a commit that referenced this issue Mar 8, 2023
@damiannolan @mergify
Adding 09-localhost loopback client module (#3229)
12f38ca 
feat: adding 09-localhost loopback client module [\#3034](#3034). Please see the 09-localhost documentation [here](https://ibc.cosmos.network/main/ibc/light-clients/localhost/overview.html).
feat: AllowedClients on-chain param allows chains to pause usage of specific client types by removing the client type from the param.
imp: Update all channel events to use `connection_id` attribute. The `packet_connection` attribute has been deprecated.
(cherry picked from commit d840c69)

# Conflicts:
#	.github/workflows/e2e-upgrade.yaml
#	docs/ibc/events.md
#	e2e/relayer/relayer.go
#	e2e/testconfig/testconfig.go
#	e2e/tests/upgrades/upgrade_test.go
#	e2e/testsuite/codec.go
#	e2e/testsuite/grpc_query.go
#	e2e/testsuite/testsuite.go
#	modules/core/02-client/keeper/client.go
#	modules/core/02-client/keeper/proposal.go
#	modules/core/02-client/types/errors.go
#	modules/core/03-connection/keeper/verify.go
#	modules/core/03-connection/types/msgs_test.go
#	modules/core/04-channel/keeper/packet.go
#	modules/core/04-channel/types/msgs.go
colin-axner pushed a commit that referenced this issue Mar 9, 2023
@mergify @damiannolan
feat: adding 09-localhost loopback client module (backport #3229) (#3262
893b7af 
)

* Adding 09-localhost loopback client module (#3229)

feat: adding 09-localhost loopback client module [\#3034](#3034). Please see the 09-localhost documentation [here](https://ibc.cosmos.network/main/ibc/light-clients/localhost/overview.html).
feat: AllowedClients on-chain param allows chains to pause usage of specific client types by removing the client type from the param.
imp: Update all channel events to use `connection_id` attribute. The `packet_connection` attribute has been deprecated.
(cherry picked from commit d840c69)

# Conflicts:
#	.github/workflows/e2e-upgrade.yaml
#	docs/ibc/events.md
#	e2e/relayer/relayer.go
#	e2e/testconfig/testconfig.go
#	e2e/tests/upgrades/upgrade_test.go
#	e2e/testsuite/codec.go
#	e2e/testsuite/grpc_query.go
#	e2e/testsuite/testsuite.go
#	modules/core/02-client/keeper/client.go
#	modules/core/02-client/keeper/proposal.go
#	modules/core/02-client/types/errors.go
#	modules/core/03-connection/keeper/verify.go
#	modules/core/03-connection/types/msgs_test.go
#	modules/core/04-channel/keeper/packet.go
#	modules/core/04-channel/types/msgs.go

* rm -rf e2e

* rm .github/workflows/e2e-upgrade.yaml

* fix errorsmod -> sdkerrors

* ibcerror -> sdkerror in localhost client_state.go

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client 09-localhost core epic type: feature New features, sub-features or integrations
Projects
ibc-go
Archived in project
Milestone
v7.1.0
Development

Successfully merging a pull request may close this issue.

feat: adding 09-localhost loopback client module cosmos/ibc-go
1 participant
@damiannolan