You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Additionally, it seems it will also be required in validateProposedUpgradeFields as added at some point in #3451 where it was initially conceived.
In most cases, the connectionEnd that is retrieved using GetConnection is required at some later
step in the function, as such, if a new function is to be added, it should return the open connection end if it exists.
Proposal
Add a new function that encapsulates both these steps; checks for existence and if the connection's state is OPEN, Bikeshed the naming.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
There's many instances of code that requires a connection to exist and be open:
During
AcknowledgePacket
During
RecvPacket
During
ChanOpenTry
During
ChanOpenAck
During
ChanOpenConfirm
During
ChanCloseInit
During
ChanCloseConfirm
Additionally, it seems it will also be required in
validateProposedUpgradeFields
as added at some point in #3451 where it was initially conceived.In most cases, the
connectionEnd
that is retrieved usingGetConnection
is required at some laterstep in the function, as such, if a new function is to be added, it should return the open connection end if it exists.
Proposal
Add a new function that encapsulates both these steps; checks for existence and if the connection's state is OPEN, Bikeshed the naming.
For Admin Use
The text was updated successfully, but these errors were encountered: