chore: remove IsOpen and IsClosed channel methods #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner and
AdityaSripal
as code owners
damiannolan
requested review from
crodriguezvega,
chatton,
DimitrisJim and
charleenfei
DimitrisJim
approved these changes
Jan 23, 2024
Indeed! why not :) |
crodriguezvega
approved these changes
Jan 23, 2024
|
If we're removing these functions, do you agree on closing this issue then? :) |
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
(cherry picked from commit e49cadd)
damiannolan
added a commit
that referenced
this pull request
Jan 23, 2024
|
Happy with the change! But it shouldn't have been backported if it is removing functions? |
Indeed! My bad, I didn't realise these were in v8.0.0 |
|
Are they? Pretty sure we added these with chan upgradability but could be wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
IsClosedandIsOpenchannel methods.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.