Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint.ChanUpgradeAck function #3685

Closed
3 tasks
colin-axner opened this issue May 29, 2023 · 2 comments · Fixed by #3715
Closed
3 tasks

Add endpoint.ChanUpgradeAck function #3685

colin-axner opened this issue May 29, 2023 · 2 comments · Fixed by #3715
Assignees
@DimitrisJim
Labels
04-channel testing Testing package and unit/integration tests
Milestone
04-channel upgrad...

Comments

@colin-axner
Copy link
Contributor

Summary

Similar to endpoint.ChanOpenAck and endpoint.ChanUpgradeInit, we should have a endpoint.ChanUpgradeTry

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests 04-channel labels May 29, 2023
@colin-axner colin-axner added this to the 04-channel upgrades alpha milestone May 29, 2023
@DimitrisJim DimitrisJim self-assigned this May 29, 2023
@DimitrisJim DimitrisJim moved this to In progress in ibc-go May 29, 2023
@DimitrisJim DimitrisJim moved this from In progress to On hold in ibc-go May 29, 2023
@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 29, 2023 •
edited
Loading

pending on spec changes getting decided/merged though if we do decide to just pass the channel (as opposed to the flush status as per spec) this shouldn't be blocked.

@DimitrisJim DimitrisJim moved this from On hold to In progress in ibc-go May 31, 2023
@DimitrisJim DimitrisJim mentioned this issue May 31, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim linked a pull request May 31, 2023 that will close this issue
Add endpoint ChanUpgradeAck #3715
Merged
9 tasks
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go Jun 1, 2023
@damiannolan
Copy link
Contributor

closed by #3715

@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Jun 6, 2023
@DimitrisJim DimitrisJim moved this from Todo to Done in ibc-go Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
04-channel testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

Successfully merging a pull request may close this issue.

Add endpoint ChanUpgradeAck cosmos/ibc-go
3 participants
@damiannolan @DimitrisJim @colin-axner