Add endpoint ChanUpgradeAck #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
colin-axner
reviewed
Jun 1, 2023
DimitrisJim
force-pushed
the
jim/add-endpoint-chanupgradeack
branch
from
305f177 to
c120ba8
Compare
DimitrisJim
requested review from
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
|
This can go before #3731 or after. I'll rebase either/or and fix the calls here. |
charleenfei
approved these changes
Jun 2, 2023
DimitrisJim
force-pushed
the
jim/add-endpoint-chanupgradeack
branch
from
c120ba8 to
f1265af
Compare
damiannolan
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Nice one @DimitrisJim, lgtm! Really nice to have small clean PRs that can fly through the review process ❤️
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3685
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.