Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code_id_key from GenesisContract #3959

Closed
3 tasks done
crodriguezvega opened this issue Jun 26, 2023 · 1 comment
Closed
3 tasks done

Remove code_id_key from GenesisContract #3959

crodriguezvega opened this issue Jun 26, 2023 · 1 comment
Assignees
@crodriguezvega
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
08-wasm/v0.1.0

Comments

@crodriguezvega
Copy link
Contributor

Surfaced from Interchain IBC team's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

Summary

Remove code_id_key from GenesisContract.

Problem Definition

The code ID key is used as the key where to store the contract's byte code during genesis import. However, the code ID key can be generated automatically: hash the contract byte code + prepend codeId key prefix. Therefore it's not really needed in GenesisContract, which the contract byte code is enough.

Proposal

  • Remove code_id_key from GenesisContract.
  • Generate the code ID key automatically when importing the contracts.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Jun 26, 2023
@crodriguezvega crodriguezvega added this to the v7.3.0 milestone Jun 26, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 26, 2023
@crodriguezvega crodriguezvega mentioned this issue Jun 26, 2023
Closed
3 tasks
@crodriguezvega crodriguezvega modified the milestones: v7.3.0, 08-wasm/v1.0.0 Jun 27, 2023
@crodriguezvega crodriguezvega mentioned this issue Jul 7, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega self-assigned this Jul 7, 2023
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Jul 7, 2023
@crodriguezvega
Copy link
Contributor Author

Closed by #4032

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
08-wasm/v0.1.0
Development

No branches or pull requests
1 participant
@crodriguezvega