Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge storeWasmCode and importWasmCode functions #3963

Closed
2 of 3 tasks
crodriguezvega opened this issue Jun 26, 2023 · 1 comment
Closed
2 of 3 tasks

Merge storeWasmCode and importWasmCode functions #3963

crodriguezvega opened this issue Jun 26, 2023 · 1 comment
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
08-wasm/v0.1.0

Comments

@crodriguezvega
Copy link
Contributor

Surfaced from Interchain IBC team's review of 08-wasm at hash https://github.com/strangelove-ventures/ibc-go/commit/96e9930ab87a171a3ae6ac9717ee25bfda77212b

The functionality of storeWasmCode and importWasmCode is pretty much the same, so we should merge them in a single function. Completing #3959 before would make this change easier.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Jun 26, 2023
@crodriguezvega crodriguezvega added this to the v7.3.0 milestone Jun 26, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 26, 2023
@crodriguezvega crodriguezvega modified the milestones: v7.3.0, 08-wasm/v1.0.0 Jun 27, 2023
@crodriguezvega crodriguezvega mentioned this issue Jul 14, 2023
Merged
9 tasks
@crodriguezvega
Copy link
Contributor Author

Closed by #4088

@github-project-automation github-project-automation bot moved this from Todo to Done in ibc-go Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
08-wasm/v0.1.0
Development

No branches or pull requests
1 participant
@crodriguezvega