Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for indicating Mashal/Unmarshaling failures in ICA #4291

Closed
2 of 3 tasks
DimitrisJim opened this issue Aug 7, 2023 · 3 comments · Fixed by #6904
Closed
2 of 3 tasks

Add error for indicating Mashal/Unmarshaling failures in ICA #4291

DimitrisJim opened this issue Aug 7, 2023 · 3 comments · Fixed by #6904

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Aug 7, 2023

Summary

Found in #4161 (comment) and issues of this kind might be opened for other places while #3778 is getting worked on.

In short, we seem to be using ErrUnknownDataType liberally in ica even in cases where it doesn't make much sense (i.e marshalling/unmarhalling errors).


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chandiniv1
Copy link
Contributor

@DimitrisJim can I work on this issue?

@crodriguezvega
Copy link
Contributor

@DimitrisJim can I work on this issue?

Yes, @chandiniv1. Thank you!

@chandiniv1
Copy link
Contributor

@crodriguezvega Is this issue about returning the actual error instead of the custom error (ErrUnknownDataType) during marshalling and unmarshalling failures, or is there something else involved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants