Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error for indicating Mashal/Unmarshaling failures #6904

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Add error for indicating Mashal/Unmarshaling failures #6904

merged 9 commits into from
Jul 26, 2024

Conversation

chandiniv1
Copy link
Contributor

closes: #4291

@damiannolan
Copy link
Member

I would recommend using ibcerrors.InvalidType as we do in transfer.

@crodriguezvega
Copy link
Contributor

I would recommend using ibcerrors.InvalidType as we do in transfer.

I applied this suggestion in 8fc5b61!

DimitrisJim
DimitrisJim approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion lgtm. we use this type for cast failures too but don't mind it being re-used for these sort of failures.

crodriguezvega
crodriguezvega approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chandiniv1!

@crodriguezvega crodriguezvega merged commit 4a70db8 into cosmos:main Jul 26, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees

@crodriguezvega crodriguezvega

@DimitrisJim DimitrisJim

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error for indicating Mashal/Unmarshaling failures in ICA
4 participants
@chandiniv1 @damiannolan @crodriguezvega @DimitrisJim