Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary deps in simapp #4552

Closed
3 tasks
colin-axner opened this issue Sep 4, 2023 · 3 comments
Closed
3 tasks

Remove unnecessary deps in simapp #4552

colin-axner opened this issue Sep 4, 2023 · 3 comments
Labels
icebox Issues that we will not address for the time being needs discussion Issues that need discussion before they can be worked on

Comments

@colin-axner
Copy link
Contributor

Summary

Remove dependencies which are not strictly needed

Problem Definition

Our simapp contains module we do not use nor test, see comment on the circuit module

Proposal

Remove unnecessary deps such as:

  • circuit
  • evidence
  • feegrant

Discussion point:
our simapp is likely used as a reference for chains, that would be the primary benefit of including unnecessary deps


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the needs discussion Issues that need discussion before they can be worked on label Sep 4, 2023
@colin-axner colin-axner changed the title Remove unnecessary deps Remove unnecessary deps in simapp Sep 4, 2023
@faddat
Copy link
Contributor

faddat commented Sep 9, 2023

I recommend keeping these dependencies, as well as adding x/nft due the fact that I'm certain that the ibc-go simapp is used as a reference.

We should also make sure that when using the wasm clients feature, we don't leave any naming ambiguous.

@crodriguezvega crodriguezvega added the icebox Issues that we will not address for the time being label Sep 11, 2023
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Sep 11, 2023

After discussing, once the testing simapp has its own go.mod then ibc-go would not have anymore the unnecessary dependencies.

@crodriguezvega
Copy link
Contributor

Now that #3968 is closed, those dependencies have been removed from ibc-go's go.mod.

@github-project-automation github-project-automation bot moved this to Done 🥳 in ibc-go Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Issues that we will not address for the time being needs discussion Issues that need discussion before they can be worked on
Projects
Status: Done 🥳
Development

No branches or pull requests

3 participants