Move simapp binary into own go.mod or e2e

[colin-axner]

Summary

The ibc-go simapp should be its own go.mod

Problem Definition

With the upgrade to Eden (sdk v0.50), a lot of sdk modules have become their own go.mod. This is creating a lot of unnecessary dependencies for ibc-go modules, ibc core and the ibc-go apps do not need to depend on several sdk modules included in simapp.

I believe there will be side benefits as well, such as having ibc-go always be a dependency of any binary, see #3039 (comment)

Proposal

Make simapp its own go.mod. I don't have a suggestion yet if we should pin the version or update it as necessary. The main concern would probably be compatibility with e2e's

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[damiannolan]

Preliminary add to v8 milestone, lets see if we can get this in before releasing v8!

[damiannolan]

I definitely agree with this proposal, additionally simapp is not only concerned with the testing pkg used for unit / integration testing anymore, it is also now used heavily with e2e when dockerised.

What do you think about moving simapp to the root of the repo when making it it’s own go module?
Would be shorter and more appropriate import path: github.com/comos/ibc-go/simapp

Would you propose we shadow the ibc-go major version suffix, or not? The only benefit I see to it is possibly less confusion around versioning, and in particular versioning of upgrade handlers will continue to roll in tandem with ibc-go.

[colin-axner]

What do you think about moving simapp to the root of the repo when making it it’s own go module?

This sounds great to me

Would you propose we shadow the ibc-go major version suffix, or not?

Probably shadow or never do a major version release of simapp. ie we could do v0.8.0 for v8

[chatton]

Did very brief investigation in #4117, I think we can tackle this as soon as the sdk 0.50 upgrade is done.

[colin-axner]

Updated idea here would be to duplicate the simapp in testing and pull out all the logic needed for the binary into its own go.mod (optionally could be in e2e go.mod). This simapp could likely import the other standalone go.mods (08-wasm, callbacks) and we could have one simd for ibc-go again. This should allow us to trim down the testing app within the testing pkg and remove unnecessary deps like:

cosmossdk.io/x/circuit v0.1.1
cosmossdk.io/x/evidence v0.1.1
cosmossdk.io/x/feegrant v0.1.1

[crodriguezvega]

We decided in the engineering call to move it to its own go.mod.