Make simapp its own gomod [Don't review] #4117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
changed the title
3 tasks
DimitrisJim
reviewed
Jul 18, 2023
Dockerfile
Outdated
| #ADD testing testing | ||
| #ADD modules modules | ||
| #ADD LICENSE LICENSE | ||
| ADD . . |
There was a problem hiding this comment.
this might turn out to be slightly annoying, there's no simd binary now
There was a problem hiding this comment.
can look into it, probs makefile tweaks.
There was a problem hiding this comment.
doesn't make build below create the binary?
There was a problem hiding this comment.
this should be finding the main.go in cmd, not the one in testing. Building locally, this builds the binary for that main (build_test_matrix) byt not the one for simapp/simd.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
- Coverage 79.48% 79.47% -0.02%
==========================================
Files 188 188
Lines 13033 13035 +2
==========================================
Hits 10359 10359
- Misses 2243 2245 +2
Partials 431 431
|
3 tasks
|
closings this PR, it can be used as a reference for the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3968
A few things that need to be done
I believe this is because the capability module that is being used in the simapp module is still referencing ibc-go. Once the sdk 0.50 upgrade is done, this will no longer be the case, (thanks @damiannolan !) After that, this problem should go away.
decouple ibc-go go.mod from simapp go.mod. Currently there is a local pin to simapp to maintain existing functionality (there is not a current tag that exists to import cleanly from, I think this can be handled post sdk-50 )
Clean up Dockerfile, I didn't investigate yet, but it looks like additional files need to be added to the docker context now to build the image correctly.
Remove dependency on simapp module from ibc-go, this largely comes in the form of
simapp.Setup(...)in a lot of our tests.Usage of
suite.chainA.GetSimApp()throughout all our tests. We have an assumption in all of our tests that we are using aSimAppinstance directly. Can we potentially operate on an interface?Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.