Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus state in the wasm client #4612

Closed
faddat opened this issue Sep 9, 2023 · 1 comment
Closed

Consensus state in the wasm client #4612

faddat opened this issue Sep 9, 2023 · 1 comment

Comments

@faddat
Copy link
Contributor

faddat commented Sep 9, 2023

Currently, we're storing binaries in the repository. I'd much rather that we store the contract code here, or alternatively put the contracts in another repository, which is built in CI. I think that this would make the flow clearer. I've noticed that no PR's to the wasm-clients branch actually pass the tests for the wasm client, and I have a feeling that could be in the contract. Each one always complains of a missing timestamp field.

From looking at wasm.proto and the tendermint proto file, we can see that that tendermint has a timestamp, while in wasm, we are dealing with only a data field. I'm going to assume that the isssue is where these interact.

@faddat faddat changed the title Improve WASM client development flow Consensus state in the wasm client Sep 9, 2023
@faddat
Copy link
Contributor Author

faddat commented Sep 9, 2023

I think that @misko9 solved this issue, closing.

Thanks Steve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant