Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix wasm client tests #4613

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 9, 2023

  • Unit tests: temporarily disable grandpa testing, update TestInitializeTendermint(), remove unnecessary test from TestConsensusStateValidateBasic(), change the update state result's height type.
  • TestVerifyMembershipGrandpa working again
  • TestVerifyNonMembershipGrandpa, TestInitializeGrandpa, TestStatusGrandpa, and TestExportGenesisGrandpa working again
  • TestCheckSubstituteAndUpdateStateGrandpa, TestVerifyHeaderGrandpa, TestUpdateStateGrandpa, TestVerifyUpgradeGrandpa working again
  • Run linter
  • Add instructions for re-creating grandpa test data
  • Add space after comment delimiter

Description

Note: Steve from Strangelove is the person this PR should be attributed to. This is just a cherry picking of the steve/feat/wasm-clients branch from strangelove.

https://github.com/strangelove-ventures/ibc-go/commits/steve/feat/wasm-clients

Many thanks to Steve (@misko9 ) for finding and solving the issue that was causing tests to fail.

Commit Message / Changelog Entry

fix: wasm client tests (credit to @misko9 )

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

TestInitializeTendermint(), remove unnecessary test from
TestConsensusStateValidateBasic(), change the update state result's
height type.
TestStatusGrandpa, and TestExportGenesisGrandpa working again
TestUpdateStateGrandpa, TestVerifyUpgradeGrandpa working again
@faddat faddat changed the title chore: cherry pick in changes from Strangelove chore: fix wasm client tests Sep 9, 2023
@faddat
Copy link
Contributor Author

faddat commented Sep 9, 2023

@crodriguezvega
Copy link
Contributor

@faddat, is this a duplicate of #4306? Or are there any extra changes in this PR? If both PRs are the same, I'd prefer to close this one, since we already started reviewing Steve's PR and left there some comments.

@faddat
Copy link
Contributor Author

faddat commented Sep 11, 2023

Thanks for bringing this to my attention! this is 100% a dupe of @misko9 's pr.

@faddat faddat closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants