Investigate failing TestV6ToV7ChainUpgrade test

[chatton]

Summary

ref #4591 (comment)

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[chatton]

I ran the test locally with the golang relayer (ghcr.io/cosmos/relayer:latest) and it passes, it seems to only fail with hermes (colinaxner/hermes:v1.6.0)

[chatton]

Another update, making the following changes causes the test to pass

--- a/e2e/tests/upgrades/upgrade_test.go
+++ b/e2e/tests/upgrades/upgrade_test.go
@@ -578,6 +578,11 @@ func (s *UpgradeTestSuite) TestV6ToV7ChainUpgrade() {
                s.AssertTxSuccess(transferTxResp)
        })

+       s.StopRelayer(ctx, relayer)
+       s.StartRelayer(relayer)
+
+       s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")
+
        t.Run("packets are relayed", func(t *testing.T) {
                s.AssertPacketRelayed(ctx, chainA, channelA.PortID, channelA.ChannelID, 1)

I recall a setting for hermes which caused it to not pick up on new chains (potentially losing track of them after the chain upgrade), restarting may be causing it to do a search and find them again.

[colin-axner]

Is this issue still relevant?

[chatton]

I think it's not, we ended up adding code to do a restart of hermes.

The hermes issue seems to still be open.

I'll close this issue as the upgrade test is resolved on our side.