-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for ibc-go version after a chain upgrade #3579
Comments
Since in master `cored` we migrate to IBC v7 and Hermes has this bug informalsystems/hermes#3579 when it is not able to detect IBC version change we have to restart the relayer on cored version change. This PR adds functionality to automatically restart Hermes if cored version returned by API changes.
We recently ran into some issues with our upgrade tests upgrading from ibc-go v6 to v7 and are seeing verify similar behaviour We noticed that if we restart hermes after the chain upgrade, everything works as expected. Note: this wasn't an issue with upgrading from v7 to v7.1, and from v7 to v8, everything worked as expected. By adding a restart here in our upgrade test it passed. Full hermes logs here
|
I also confirms that upgrading from ibc-go v2.2 to v7.2 also requires an restart |
Summary
The Hermes relayer should be able to detect version changes in upgrades and continue to relay without requiring a restart.
Problem Definition
The Hermes relayer needs to be restarted after a chain upgrade which includes updating ibc-go from v4 to v7, otherwise it cannot correctly relay messages. It would be nice if hermes could detect the upgrade and check ibc version changes, so the restart would not be needed.
This is the error log produced right after the upgrade.
Proposal
As stated, Hermes should check and update ibc-go version after an upgrade, without requiring a restart.
Acceptance Criteria
Do an upgrade which contains update of ibc-go from v4 to v7, and the relayer should continue to relay correctly.
For Admin Use
The text was updated successfully, but these errors were encountered: