Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically restart Hermes relayer on cored version change #286

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

ysv
Copy link
Contributor

@ysv ysv commented Sep 8, 2023

Description

Since in master cored we migrate to IBC v7 and Hermes has this bug informalsystems/hermes#3579 when it is not able to detect IBC version change we have to restart the relayer on cored version change.
This PR adds functionality to automatically restart Hermes if cored version returned by API changes.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner September 8, 2023 12:02
@ysv ysv requested review from dzmitryhil, vertex451, miladz68 and wojtek-coreum and removed request for a team September 8, 2023 12:02
@ysv ysv force-pushed the yaroslav/restart-ibc-relayer-after-upgrade branch from 5a99f1d to 158e0b3 Compare September 8, 2023 12:02
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @vertex451, and @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451 and @wojtek-coreum)

@ysv ysv merged commit aa3c0f1 into master Sep 8, 2023
@ysv ysv deleted the yaroslav/restart-ibc-relayer-after-upgrade branch September 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants