Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: add function to get balance and migrate existing calls to CosmosChain's GetBalance #4661

Closed
crodriguezvega opened this issue Sep 14, 2023 · 2 comments · Fixed by #4683
Closed

e2e: add function to get balance and migrate existing calls to CosmosChain's GetBalance #4661

crodriguezvega opened this issue Sep 14, 2023 · 2 comments · Fixed by #4683
Assignees
@trinitys7
Labels
e2e good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@crodriguezvega
Copy link
Contributor

This PR added a function to query all balances. We should implement a similar function to get the balance for a specific account address and denomination, and migrate the calls to GetBalance in our e2e tests (like this one here) to use the new function instead.
@crodriguezvega crodriguezvega added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces e2e labels Sep 14, 2023
@crodriguezvega crodriguezvega mentioned this issue Sep 14, 2023
Merged
9 tasks
@trinitys7
Copy link
Contributor

hi @crodriguezvega can I try to do this ?

@crodriguezvega
Copy link
Contributor Author

Yes, sure! Thank you, @trinitys7!

@trinitys7 trinitys7 mentioned this issue Sep 17, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinitys7 trinitys7

Labels
e2e good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e : migrate interchaintest.GetBalance to CosmosChain's GetBalance caelus-labs/ibc-go
2 participants
@crodriguezvega @trinitys7