e2e: check that IBC tokens on destination chain have metadata #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
charleenfei
as code owners
Closed
2 tasks
crodriguezvega
requested review from
damiannolan,
chatton and
DimitrisJim
as code owners
crodriguezvega
commented
Sep 12, 2023
chatton
reviewed
Sep 13, 2023
e2e/tests/transfer/base_test.go
Outdated
Comment on lines
108
to
117
| if testvalues.TokenMetadataFeatureReleases.IsSupported(chainBVersion) { | ||
| t.Run("metadata for token exists on chainB", func(t *testing.T) { | ||
| balances, err := chainB.AllBalances(ctx, chainBAddress, true) | ||
| s.Require().NoError(err) | ||
|
|
||
| // balance for IBC token returns a human-readable denomination | ||
| s.Require().Equal(chainBIBCToken.GetFullDenomPath(), balances[1].Denom) | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
ah it looks like we have been doing some overlapping work. I have a similar thing in this PR however I did not know we already had `TokenMetadataFeatureReleases!
There was a problem hiding this comment.
Ah, I just added it for this test. We can fix the merge conflicts later.
added 2 commits
September 14, 2023 13:11
…all-balances-response-returns-human-readable-denomination # Conflicts: # e2e/testsuite/grpc_query.go
colin-axner
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Thank you @crodriguezvega! And thank you for adding the bank grpc 🙏
…all-balances-response-returns-human-readable-denomination
crodriguezvega
deleted the
carlos/3768-check-in-transfer-e2e-test-that-all-balances-response-returns-human-readable-denomination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3768
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.