Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ics27(upgrades): move type cast of next middleware app to if block to allow nil apps to function correctly with controller module #5456

Closed
3 tasks
damiannolan opened this issue Dec 19, 2023 · 2 comments
Closed
3 tasks

ics27(upgrades): move type cast of next middleware app to if block to allow nil apps to function correctly with controller module #5456

damiannolan opened this issue Dec 19, 2023 · 2 comments
Assignees
@DimitrisJim
Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature type: bug Something isn't working as expected
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

Summary

Allow nil app by moving cast in if im.app != nil block in callbacks.

e.g. Move this to here

The above should be done for each callback function in the controller submodule.

  • ChanUpgradeInit
  • ChanUpgradeAck
  • ChanUpgradeOpen
  • ChanUpgradeRestore

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: bug Something isn't working as expected audit Feedback from implementation audit channel-upgradability Channel upgradability feature labels Dec 19, 2023
@damiannolan damiannolan added this to the 04-channel upgrades RC milestone Dec 19, 2023
@DimitrisJim DimitrisJim self-assigned this Dec 19, 2023
@DimitrisJim DimitrisJim mentioned this issue Dec 19, 2023
Merged
9 tasks
@DimitrisJim
Copy link
Contributor

can be closed after #5467 is merged!

@DimitrisJim
Copy link
Contributor

completed in #5467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature type: bug Something isn't working as expected
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades RC
Development

No branches or pull requests
2 participants
@damiannolan @DimitrisJim