Add implementations for OnChanUpgradeOpen and OnChanUpgradeRestore for controller.

[DimitrisJim]

Description

note: all panic in callbacks should be unreachable.

closes: #5457

Commit Message / Changelog Entry

fix: add implementations that forward call to callback if app is set

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[damiannolan]

Awesome, thank you @DimitrisJim! 🚀

[damiannolan]

Suppose there will never an expError because the func can only panic in one case.

It should be possible to set some mock app or middleware as the app which doesn't implement the interface. Maybe could reuse something from #5406 with expPanics, where instead of using nil we use a mock that doesn't implement the interface:

if expPanics {
    cbs = controller.NewIBCMiddleware(ibcmock.NewBlockUpgradeMiddleware(), suite.chainA.GetSimApp().ICAControllerKeeper)
}

Happy to do it in a follow up if we go with the mock upgrade middleware

[DimitrisJim]

Happy to do it in a follow up if we go with the mock upgrade middleware

Sounds perfect to me, I'll open a quick issue for it. (I'll clean up expError for now)

[DimitrisJim]

#5471

[chatton]

LGTM thanks @DimitrisJim