Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ics27(upgrades): Implement ChanUpgradeRestore and ChanUpgradeOpen callbacks #5457

Closed
3 tasks
damiannolan opened this issue Dec 19, 2023 · 1 comment
Closed
3 tasks

ics27(upgrades): Implement ChanUpgradeRestore and ChanUpgradeOpen callbacks #5457

damiannolan opened this issue Dec 19, 2023 · 1 comment
Assignees
@DimitrisJim
Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

Summary

These callbacks seem to have been missed in PR reviews.

Both callbacks should be nil checking the app and if middleware is enabled and if so, then passing through the next app/middleware in the app stack.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added audit Feedback from implementation audit channel-upgradability Channel upgradability feature labels Dec 19, 2023
@damiannolan damiannolan added this to the 04-channel upgrades RC milestone Dec 19, 2023
@DimitrisJim DimitrisJim mentioned this issue Dec 19, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim self-assigned this Dec 19, 2023
@DimitrisJim DimitrisJim mentioned this issue Dec 19, 2023
Merged
9 tasks
@DimitrisJim
Copy link
Contributor

done in #5467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades RC
Development

No branches or pull requests
2 participants
@damiannolan @DimitrisJim