Consider deleting upgrade information only rather than calling abort in TimeoutExecuted

[colin-axner]

Summary

When a timeout is executed on an ORDERED channel, the channel will close. We want to delete upgrade information in this case. Currently we call abort which will write an error receipt and reopen the channel. The code is currently structured to close after the opening, but if it is moved around it could introduce an accidental bug. We should consider calling deleteUpgradeInfo directly rather than aborting the full upgrade. Once a channel closes the counterparty will be able to close as well, regardless of where the channels were in the upgrade process.

Discussed during our internal security audit of channel upgradability (v8.1.x)

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[hoangdv2429]

Can I tackle on this issue sir @colin-axner

[crodriguezvega]

@hoangdv2429 Sounds good, thank you!