Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Delete upgrade information only rather than calling abort in TimeoutExecuted #5764

Conversation

hoangdv2429
Copy link
Contributor

Description

closes: #5742


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1c0c756) 81.59% compared to head (3783276) 81.54%.
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5764      +/-   ##
==========================================
- Coverage   81.59%   81.54%   -0.05%     
==========================================
  Files         199      199              
  Lines       15167    12079    -3088     
==========================================
- Hits        12375     9850    -2525     
+ Misses       2326     1764     -562     
+ Partials      466      465       -1     
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 84.15% <100.00%> (+0.45%) ⬆️
...ules/apps/27-interchain-accounts/types/metadata.go 81.01% <100.00%> (+1.21%) ⬆️
modules/apps/transfer/types/codec.go 100.00% <ø> (+13.79%) ⬆️
modules/core/03-connection/keeper/verify.go 83.63% <100.00%> (+3.27%) ⬆️
modules/core/03-connection/types/connection.go 100.00% <ø> (+10.16%) ⬆️
modules/core/04-channel/keeper/handshake.go 90.22% <100.00%> (+0.01%) ⬆️
modules/core/04-channel/keeper/timeout.go 95.15% <100.00%> (-0.25%) ⬇️
modules/core/04-channel/keeper/upgrade.go 92.06% <100.00%> (-0.41%) ⬇️
modules/apps/transfer/keeper/relay.go 90.32% <60.00%> (-0.62%) ⬇️
modules/apps/transfer/types/packet.go 88.88% <50.00%> (-3.80%) ⬇️
... and 1 more

... and 160 files with indirect coverage changes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing that last commit @crodriguezvega ❤️

LGTM!

@crodriguezvega crodriguezvega merged commit fc0bfab into cosmos:main Feb 6, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider deleting upgrade information only rather than calling abort in TimeoutExecuted
6 participants