Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify CheckSubstituteAndUpdateState to set client state #599

Closed
3 tasks
colin-axner opened this issue Dec 6, 2021 · 0 comments
Closed
3 tasks

modify CheckSubstituteAndUpdateState to set client state #599

colin-axner opened this issue Dec 6, 2021 · 0 comments
Assignees
@damiannolan
Labels
02-client core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

For the same reasoning as #284, #285, and #286, CheckSubstituteAndUpdateState should require light clients to set the updated client and consensus state.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the vNext milestone Dec 6, 2021
@colin-axner colin-axner self-assigned this Dec 6, 2021
@crodriguezvega crodriguezvega modified the milestones: vNext, v4.0.0 Dec 16, 2021
@crodriguezvega crodriguezvega added core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jan 3, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 3, 2022
@crodriguezvega crodriguezvega moved this from Todo to On hold in ibc-go Jan 4, 2022
@colin-axner colin-axner moved this from On hold to Todo in ibc-go Feb 3, 2022
@colin-axner colin-axner removed their assignment Feb 7, 2022
@damiannolan damiannolan mentioned this issue Mar 25, 2022
Merged
9 tasks
@damiannolan damiannolan self-assigned this Mar 25, 2022
@damiannolan damiannolan moved this from Todo to In review in ibc-go Mar 25, 2022
Repository owner moved this from In review to Done in ibc-go Mar 30, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@gupadhyaya
fill in all the missing fields of status rpc (cosmos#599)
3a518be 
Fill in all the missing fields of Status() ROC for compatibility with Tendermint RPC.
Fixes cosmos#241.
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner