Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MsgModuleQuerySafe requests field as non-nullable #6582

Closed
3 tasks
DimitrisJim opened this issue Jun 12, 2024 · 2 comments · Fixed by #6598
Closed
3 tasks

Mark MsgModuleQuerySafe requests field as non-nullable #6582

DimitrisJim opened this issue Jun 12, 2024 · 2 comments · Fixed by #6598
Assignees
@neitdung
Labels
27-interchain-accounts change: api breaking Issues or PRs that break Go API (need to be release in a new major version)

Comments

@DimitrisJim
Copy link
Contributor

Randomly bumped into it, the requests field on the query safe message is required to be populated in the Validation fn. There's no benefit to keeping it as a pointer.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@neitdung
Copy link
Contributor

Hi @DimitrisJim, could I take this issue?

@DimitrisJim DimitrisJim added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Jun 13, 2024
@DimitrisJim
Copy link
Contributor Author

absolutely @neitdung, don't see why not.

@neitdung neitdung mentioned this issue Jun 14, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neitdung neitdung

Labels
27-interchain-accounts change: api breaking Issues or PRs that break Go API (need to be release in a new major version)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(api!): mark MsgModuleQuerySafe requests field as non-nullable decentrio/ibc-go
2 participants
@DimitrisJim @neitdung