Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api!): mark MsgModuleQuerySafe requests field as non-nullable #6598

Merged
merged 17 commits into from
Jun 28, 2024

Conversation

neitdung
Copy link
Contributor

@neitdung neitdung commented Jun 14, 2024

Description

closes: #6582

  • Mark MsgModuleQuerySafe.requests as non-nullable
  • Modify tests and docs for compatible with the change

Commit Message / Changelog Entry

chore: mark MsgModuleQuerySafe requests field as non-nullable

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! Not sure what is up with link checker, all links it reports as 404, my browser finds.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @neitdung. Question for the team: should we consider this an API-breaking change?

@DimitrisJim
Copy link
Contributor

should we consider this an API-breaking change?

it is? unless I'm missing something 😄

@crodriguezvega
Copy link
Contributor

should we consider this an API-breaking change?

it is? unless I'm missing something 😄

I might also be missing something, but I thought it could be because of this change. Users of the constructor will need to (slightly) change their code to not pass a slice of pointers, right?

@DimitrisJim
Copy link
Contributor

Users of the constructor will need to (slightly) change their code to not pass a slice of pointers, right?

yup!

@crodriguezvega
Copy link
Contributor

Users of the constructor will need to (slightly) change their code to not pass a slice of pointers, right?

yup!

Ok, then I will push a commit adding a changelog and updating migration docs.

@crodriguezvega crodriguezvega changed the title chore: mark MsgModuleQuerySafe requests field as non-nullable chore(api!): mark MsgModuleQuerySafe requests field as non-nullable Jun 17, 2024
@crodriguezvega crodriguezvega merged commit b083e37 into cosmos:main Jun 28, 2024
81 of 86 checks passed
@crodriguezvega crodriguezvega deleted the requests-not-nullable branch June 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark MsgModuleQuerySafe requests field as non-nullable
3 participants