-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api!): mark MsgModuleQuerySafe requests field as non-nullable #6598
Conversation
…ibc-go into requests-not-nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks! Not sure what is up with link checker, all links it reports as 404, my browser finds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @neitdung. Question for the team: should we consider this an API-breaking change?
it is? unless I'm missing something 😄 |
I might also be missing something, but I thought it could be because of this change. Users of the constructor will need to (slightly) change their code to not pass a slice of pointers, right? |
yup! |
Ok, then I will push a commit adding a changelog and updating migration docs. |
Description
closes: #6582
MsgModuleQuerySafe.requests
as non-nullableCommit Message / Changelog Entry
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.