Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active channels mapping should not delete last active channel #707

Closed
3 tasks
colin-axner opened this issue Jan 10, 2022 · 0 comments · Fixed by #730
Closed
3 tasks

Active channels mapping should not delete last active channel #707

colin-axner opened this issue Jan 10, 2022 · 0 comments · Fixed by #730
Assignees
@seantking
Labels
27-interchain-accounts
Milestone
Interchain Accounts

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jan 10, 2022 •
edited
Loading

Summary

Following #700 we won't be capable of checking the connection sequences against the newly created channel since the active channel mapping is deleted upon channel closure.

Problem Definition

The connection sequences used for verifying that the new channel is created on the right connections is moved from the portID to the channel structure, but the channel ID of the old channel is removed from state upon channel closure

Proposal

Do not delete the channel ID upon channel closure. GetActiveChannel should check if the active channel is in OPEN state. If the channel is in CLOSED state, a new channel may be created to become the new active channel. This allows the connection sequence and other information in Metadata to be checked upon activating a new channel for a closed channel. The existing API may be modified to cleanly implement this new functionality.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner moved this to Todo in ibc-go Jan 10, 2022
@colin-axner colin-axner added this to the Interchain Accounts milestone Jan 10, 2022
@seantking seantking self-assigned this Jan 10, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Jan 12, 2022
@seantking seantking mentioned this issue Jan 13, 2022
Merged
9 tasks
Repository owner moved this from In progress to Done in ibc-go Jan 14, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@orkunkl @alpe
Implement PinCode and UnpinCode proposal client handlers (cosmos#707)
e7f41f2 
* Implement PinCodes proposal cli

* Implement UnpinCodes proposal cli

* Fix descriptions

* Apply suggestions from code review

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seantking seantking

Labels
27-interchain-accounts
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

Successfully merging a pull request may close this issue.

refactor: no longer removing active channel mapping on close channel cosmos/ibc-go
2 participants
@seantking @colin-axner