Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Antehandler no longer working #852

Closed
faddat opened this issue Feb 5, 2022 · 2 comments
Closed

IBC Antehandler no longer working #852

faddat opened this issue Feb 5, 2022 · 2 comments
Labels
type: bug Something isn't working as expected

Comments

@faddat
Copy link
Contributor

faddat commented Feb 5, 2022

Summary of Bug

https://www.mintscan.io/cosmos/txs/54989DC46695DD97314C4E5FACCC8234A255A8983D4456B0E2AEAAF9870DFB1C

When it was working, duplicate ibc transactions would be rejected but that is no longer happening.

Version

Gaia, Osmosis, Terra, Juno

Steps to Reproduce

screen -S gaia
git clone https://github.com/cosmos/gaia
cd gaia
bash contrib/statesync.bash

screen -S osmosis
git clone https://github.com/osmosis-labs/osmosis
cd osmosis
git checkout v6.2.0
bash scripts/statesync.sh

screen -S hermes
git clone https://github.com/notional-labs/notional
mkdir ~/.hermes
cp notional/relaying/hermes/osmo-gaia.toml ~/.hermes/config.toml
# add keys as instructed at https://github.com/notional-labs/notional/relaying/hermes
hermes start

You'll see that duplicate transactions aren't being rejected. 


____

#### For Admin Use

- [ ] Not duplicate issue
- [ ] Appropriate labels applied
- [ ] Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

@faddat Thanks for opening this issue.

I seem to be able to reproduce the problem locally running our simapp, so we will investigate this further. I have attached for reference the files tx-relayer-1.txt and tx-relayer-2.txt with the same messages committed by two different relayers in the same block.

@colin-axner @AdityaSripal I noticed that in the app.go of our simapp the antehandler is instantiated using the NewAnteHandler from cosmos-sdk/x/auth/ante instead of the custom NewAnteHandler function that is used, for example, in gaia. I guess we need to do for our simapp something similar as gaia does?

@crodriguezvega crodriguezvega added the type: bug Something isn't working as expected label Feb 6, 2022
@crodriguezvega
Copy link
Contributor

Closed by #950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
Archived in project
Development

No branches or pull requests

2 participants