Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetTimestampAtHeight to client state interface #876

Closed
6 tasks done
colin-axner opened this issue Feb 7, 2022 · 1 comment
Closed
6 tasks done

Add GetTimestampAtHeight to client state interface #876

colin-axner opened this issue Feb 7, 2022 · 1 comment
Assignees

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Feb 7, 2022

Summary

The solo machine cannot currently process timeouts because it does not have a consensus state associated with the timeout height until after processing the timeout. Core IBC assumes a consensus state exists in state for the timeout height, but solo machines stores the consensus state in the client state.

We should add a function GetTimestampAtHeight to the client state function which returns the timestamp at a given consensus state height.

Splitting PR recommendation

PR 1

Add the GetTimetstampAtHeight to each client state + unit tests

  • 06-solomachine
  • 07-tendermint
  • 09-localhost

PR 2

Modify connection keeper GetTimestampAtHeight to use the client state interface function. See if it is possible to write a test for solo machines to send a successful timeout msg

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner moved this to Todo in ibc-go Feb 7, 2022
@colin-axner colin-axner moved this from Todo to In review in ibc-go Mar 8, 2022
@crodriguezvega crodriguezvega moved this from In review to In progress in ibc-go Mar 9, 2022
@seantking seantking moved this from In progress to In review in ibc-go Mar 11, 2022
@crodriguezvega crodriguezvega moved this from In review to Todo in ibc-go Mar 21, 2022
@seantking seantking moved this from Todo to In review in ibc-go Mar 29, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@crodriguezvega
Copy link
Contributor

I have asked today if it's possible to merge Colin's PR to move forward with PR1 of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants