Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS2: Add getTimestampAtHeight function to client state interface #689

Closed
colin-axner opened this issue Mar 17, 2022 · 0 comments · Fixed by #813
Closed

ICS2: Add getTimestampAtHeight function to client state interface #689

colin-axner opened this issue Mar 17, 2022 · 0 comments · Fixed by #813
Assignees
Labels
implementation Tracking an external implementation of the spec. tao Transport, authentication, & ordering layer.

Comments

@colin-axner
Copy link
Contributor

In ibc-go we are rewriting the getTimestampAtHeight functionality. Currently it is housed in ICS 003, it's functionality is to obtain the consensus state at the proof height and check its timestamp value. The problem with this is the solo machine doesn't store consensus states at each height it has had a consensus state. This is because the solo machine only maintains the latest consensus state.

I propose the spec to do the same changes (or devise another way to get timeouts to work with the solo machine). This would be appreciated as some clients may have not so apparent requirements to fulfill this function. For example, the solo machine should return the timestamp of the latest consensus state. If the height passed in is > solomachine.Sequence + 1, it should return an error.

@mpoke mpoke added tao Transport, authentication, & ordering layer. implementation Tracking an external implementation of the spec. labels Mar 17, 2022
@mpoke mpoke changed the title ICS 002: Add getTimestampAtHeight function to client state interface ICS2: Add getTimestampAtHeight function to client state interface Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Tracking an external implementation of the spec. tao Transport, authentication, & ordering layer.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants