Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding UpdateStateOnMisbehaviour to 07-tendermint #1168

Merged

Conversation

damiannolan
Copy link
Member

Description

  • Adds UpdateStateOnMisbehaviour to 07-tendermint client

ref: #879 PR4


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner requested a review from seantking March 24, 2022 14:23
@damiannolan damiannolan merged commit efbc5a1 into 02-client-refactor Mar 24, 2022
@damiannolan damiannolan deleted the damian/879-update-state-on-misbehaviour branch March 24, 2022 15:07
seunlanlege pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
* adding UpdateStateOnMisbehaviour with basic test

* removing redundant return values

* removing unnecessary CommitBlock in test func

* Update modules/light-clients/07-tendermint/types/update.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants