feat: VerifyNonMembership 07-tendermint implementation #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
colin-axner,
fedekunze and
AdityaSripal
as code owners
seantking
requested review from
damiannolan,
charleenfei,
chatton and
crodriguezvega
seantking
commented
Jun 29, 2022
| proof []byte | ||
| path []byte | ||
| invalidClientID = "09-tendermint" | ||
| invalidConnectionID = "connection-100" |
There was a problem hiding this comment.
Kinda redundant vars. Open to suggestions for improvements.
damiannolan
approved these changes
Jun 29, 2022
Comment on lines
+484
to
+487
| invalidClientID = "09-tendermint" | ||
| invalidConnectionID = "connection-100" | ||
| invalidChannelID = "channel-800" | ||
| invalidPortID = "invalid-port" |
There was a problem hiding this comment.
Maybe we could just remove these vars and pass the strings in directly? Given invalidClientID and invalidConnectionID are only used once especially.
There was a problem hiding this comment.
Hmm, I think I still prefer vars for readability tbh :-D
There was a problem hiding this comment.
Sometimes I find it easier for readability without vars tbh. Depends on the complexity of the tests.
These are probably fine. But my personal choice would be to remove the client/connection id ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1291
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes