Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assert previous connection id to be empty #1797

Merged
merged 10 commits into from
Jul 28, 2022
Merged

fix: assert previous connection id to be empty #1797

merged 10 commits into from
Jul 28, 2022

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 27, 2022 •
edited
Loading

Description

closes: #1777

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner
colin-axner commented Jul 27, 2022
View reviewed changes
modules/core/03-connection/types/msgs_test.go
Comment on lines -131 to -132
{"invalid connection ID", types.NewMsgConnectionOpenTry("test/conn1", "clienttotesta", "connectiontotest", "clienttotest", clientState, prefix, []*types.Version{ibctesting.ConnectionVersion}, 500, suite.proof, suite.proof, suite.proof, clientHeight, clientHeight, signer), false},
{"invalid connection ID", types.NewMsgConnectionOpenTry("(invalidconnection)", "clienttotesta", "connectiontotest", "clienttotest", clientState, prefix, []*types.Version{ibctesting.ConnectionVersion}, 500, suite.proof, suite.proof, suite.proof, clientHeight, clientHeight, signer), false},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed one of these and replaced the other with the non empty connection ID test

damiannolan
damiannolan approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@colin-axner colin-axner merged commit 0be6c42 into main Jul 28, 2022
@colin-axner colin-axner deleted the colin/1777-remove-connection-leftovers branch July 28, 2022 22:33
mergify bot pushed a commit that referenced this pull request Jul 28, 2022
@colin-axner @mergify
fix: assert previous connection id to be empty (#1797)
45dc80a 
* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty

* add changelog entry

* update test

* add migration docs

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 0be6c42)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 28, 2022
Merged
crodriguezvega added a commit that referenced this pull request Jul 29, 2022
@mergify @colin-axner @crodriguezvega
fix: assert previous connection id to be empty (backport #1797) (#1828)
bc534e9 
* fix: assert previous connection id to be empty (#1797)

* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty

* add changelog entry

* update test

* add migration docs

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 0be6c42)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 27, 2023
@mergify @colin-axner
@crodriguezvega @ulbqb
fix: assert previous connection id to be empty (backport cosmos#1797) (…
2743786 
…cosmos#1828)

* fix: assert previous connection id to be empty (cosmos#1797)

* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty

* add changelog entry

* update test

* add migration docs

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 0be6c42)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
@mergify @colin-axner
@crodriguezvega @ulbqb
fix: assert previous connection id to be empty (backport cosmos#1797) (…
57b78cf 
…cosmos#1828)

* fix: assert previous connection id to be empty (cosmos#1797)

* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty

* add changelog entry

* update test

* add migration docs

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 0be6c42)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
@mergify @colin-axner
@crodriguezvega @ulbqb
fix: assert previous connection id to be empty (backport cosmos#1797) (…
074fa60 
…cosmos#1828)

* fix: assert previous connection id to be empty (cosmos#1797)

* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty

* add changelog entry

* update test

* add migration docs

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 0be6c42)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@ulbqb ulbqb mentioned this pull request Jul 31, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove leftover code from 03-connection handshake crossing hellos
3 participants
@colin-axner @damiannolan @crodriguezvega