Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration docs v4 to v5 #1826

Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jul 28, 2022

Description

closes: #1781
closed: #2083


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crodriguezvega crodriguezvega linked an issue Jul 28, 2022 that may be closed by this pull request
@crodriguezvega
Copy link
Contributor Author

Still a bit WiP, but open to receive feedback if I am forgetting something or if I am adding things in the wrong section.


The `RegisterRESTRoutes` function in `modules/apps/27-interchain-accounts` has been removed.

The response of a message execution on the host chain is constructed now like this:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably need to expand the explanation of this part a bit more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it could be good to give an example of how it was previously in addition to what it should look like now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it now?

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Just left one comment regarding the new interface type for MsgServiceRouter

docs/migrations/v4-to-v5.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is by far the best migrations written thus far!

Comment on lines +3 to +4
This document is intended to highlight significant changes which may require more information than presented in the CHANGELOG.
Any changes that must be done by a user of ibc-go should be documented here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably remove this section going forward. I'd assume it is just noise nowadays

docs/migrations/v4-to-v5.md Show resolved Hide resolved
docs/migrations/v4-to-v5.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thorough great work @crodriguezvega 🥇

docs/migrations/v4-to-v5.md Outdated Show resolved Hide resolved
@colin-axner
Copy link
Contributor

@crodriguezvega is this waiting on a review from someone?

@crodriguezvega
Copy link
Contributor Author

crodriguezvega commented Sep 7, 2022

@crodriguezvega is this waiting on a review from someone?

No, I just need to update accordingly to @damiannolan's and yours comment.

@colin-axner
Copy link
Contributor

Can we merge this?

@crodriguezvega
Copy link
Contributor Author

Can we merge this?

Yeap. I will merge it now.

@crodriguezvega crodriguezvega merged commit a278287 into main Sep 26, 2022
@crodriguezvega crodriguezvega deleted the carlos/#1781-create-docs-for-migration-from-v4-to-v5 branch September 26, 2022 09:19
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit a278287)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit a278287)
crodriguezvega added a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants