-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migration docs v4 to v5 #1826
docs: migration docs v4 to v5 #1826
Conversation
Still a bit WiP, but open to receive feedback if I am forgetting something or if I am adding things in the wrong section. |
docs/migrations/v4-to-v5.md
Outdated
|
||
The `RegisterRESTRoutes` function in `modules/apps/27-interchain-accounts` has been removed. | ||
|
||
The response of a message execution on the host chain is constructed now like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably need to expand the explanation of this part a bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it could be good to give an example of how it was previously in addition to what it should look like now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it now?
…https://github.com/cosmos/ibc-go into carlos/#1781-create-docs-for-migration-from-v4-to-v5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Just left one comment regarding the new interface type for MsgServiceRouter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This is by far the best migrations written thus far!
This document is intended to highlight significant changes which may require more information than presented in the CHANGELOG. | ||
Any changes that must be done by a user of ibc-go should be documented here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably remove this section going forward. I'd assume it is just noise nowadays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thorough great work @crodriguezvega 🥇
@crodriguezvega is this waiting on a review from someone? |
No, I just need to update accordingly to @damiannolan's and yours comment. |
…2309) * updating migration docs with additional ics27 host parameter * fix indentation
Can we merge this? |
Yeap. I will merge it now. |
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287)
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287)
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* wip: migration docs v4 to v5 * adding some code diffs * adding more code snippets and diffs * add link to docs * fix alignment * fix alignment * fix alignment * fix typo * code improvement * add links to sections in the document * add migration docs for #2058 * added link to PR that renamed the ante decorator * changes for #2083 * docs: updating migration docs with additional ics27 host parameter (#2309) * updating migration docs with additional ics27 host parameter * fix indentation Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit a278287) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Description
closes: #1781
closed: #2083
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes