chore: adding MsgChannelUpgradeTimeout fields and sdk.Msg interface impl
#1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
chatton
as code owners
damiannolan
commented
Jul 29, 2022
Comment on lines
+612
to
+614
| if msg.CounterpartyChannel.State != OPEN { | ||
| return sdkerrors.Wrapf(ErrInvalidChannelState, "expected: %s, got: %s", OPEN, msg.CounterpartyChannel.State) | ||
| } |
There was a problem hiding this comment.
@AdityaSripal do you think there's any additional checks we need to perform on the counterparty channel?
Maybe check the channel version is not empty?
charleenfei
reviewed
Aug 1, 2022
| return sdkerrors.Wrap(sdkerrors.ErrInvalidHeight, "proof height must be non-zero") | ||
| } | ||
|
|
||
| if msg.CounterpartyChannel.State != OPEN { |
There was a problem hiding this comment.
could the counterparty channel state be in INITUPGRADE (crossing hellos?)
There was a problem hiding this comment.
As far as I know crossing hellos are no longer supported, and won't be for channel upgrades?
cc. @AdityaSripal
charleenfei
approved these changes
Aug 2, 2022
seantking
approved these changes
Aug 3, 2022
I'm going to merge this. We can follow up with @AdityaSripal about this later 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1626
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes