Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump 02-client-refactor branch to tip of main #1867

Merged
merged 279 commits into from
Aug 3, 2022
Merged
Changes from 1 commit
Commits
Show all changes
279 commits
Select commit Hold shift + click to select a range
90a7e5f
fix mirgation docs (#1091)
colin-axner Mar 9, 2022
a7563c9
fix: handle testing update client errors (#1094)
fedekunze Mar 9, 2022
f0b94df
replace channel keeper with IBC keeper in AnteDecorator (#950)
Mar 10, 2022
d40f1da
add backport rules for v1.4.x and v2.2.x (#1085)
Mar 10, 2022
c32e4be
ibctesting: custom voting power reduction for testing (#939)
fedekunze Mar 11, 2022
3f8858a
build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (#1105)
dependabot[bot] Mar 14, 2022
e0ae0cd
build(deps): bump google.golang.org/grpc from 1.44.0 to 1.45.0 (#1098)
dependabot[bot] Mar 14, 2022
0a81a52
fix: adjust InitModule to account for empty controller and host keepe…
colin-axner Mar 15, 2022
13bc4a0
Merge pull request from GHSA-j658-c98j-fww4
crodriguezvega Mar 15, 2022
4fe874e
fixes for the documentation about handling ack for SDK <= 0.45 (#1122)
Mar 15, 2022
9e2cbc2
Allow testing to update ValidatorSet (#1003)
AdityaSripal Mar 16, 2022
c0675ee
imp: create codeql-analysis action (#1128)
fedekunze Mar 16, 2022
f83aa82
update changelog (#1131)
Mar 16, 2022
fb7a230
build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (#1…
dependabot[bot] Mar 17, 2022
dbd2df2
call packet.GetSequence() rather than passing the func as argument (#…
Mar 17, 2022
5cf580c
fix: prefix ResponseResultType enum for proto linting (#1143)
damiannolan Mar 21, 2022
163fbc4
build(deps): bump actions/cache from 2.1.7 to 3 (#1150)
dependabot[bot] Mar 21, 2022
40f9da1
fixes for go-releaser configuration (#1148)
Mar 21, 2022
a776e47
add banner image (#1158)
Mar 22, 2022
1994802
Add alpha, beta, and rc release definitions (#1151)
colin-axner Mar 22, 2022
f4a5dcb
build(deps): bump google.golang.org/protobuf from 1.27.1 to 1.28.0 (#…
dependabot[bot] Mar 22, 2022
1468382
fix typos in the controller params (#1172)
Mar 28, 2022
46b2720
add versions for new releases (#1175)
Mar 28, 2022
b132515
fix: link checker reporting broken milestone link (#1200)
damiannolan Mar 30, 2022
92cedb1
update roadmap for q2 2022 and deleted history roadmap (don't think w…
crodriguezvega Mar 31, 2022
ccc4cb8
requirements document for ICA (#1173)
Mar 31, 2022
ffa9896
imp: improve Logger performance (#1160)
fedekunze Apr 5, 2022
4271027
ICS 29: Fee Middleware (#276)
AdityaSripal Apr 6, 2022
7447b60
build(deps): bump codecov/codecov-action from 2.1.0 to 3 (#1222)
dependabot[bot] Apr 6, 2022
76e0c24
ics29: feat: CLI query commands for packets (#1229)
seantking Apr 7, 2022
35427da
add check for blocked addr for forward relayer distribution (#1231)
seantking Apr 7, 2022
89c8cf8
feat: ics29 counterparty address grpc query and CLI (#1224)
damiannolan Apr 7, 2022
8451c63
chore: fix go ctx arg naming in ics29 grpc queries (#1226)
damiannolan Apr 7, 2022
0be0d79
chore: ics29 module housekeeping cleanup (#1227)
damiannolan Apr 7, 2022
f4675d3
feat: ics29 fee enabled channel queries (#1225)
damiannolan Apr 7, 2022
311379f
chore: cleanup OnAcknowledgement and OnTimeout code ics29 (#1228)
damiannolan Apr 7, 2022
c5897ae
add changelog entry for #276 (#1233)
Apr 8, 2022
b71bbf2
feat: adding CLI for getting incentivized packets on a specific chann…
seantking Apr 8, 2022
c7209a5
chore: ics29 cleanup, addressing nits (#1236)
damiannolan Apr 11, 2022
d43fd0a
refactor: moving fn definition to bottom of file and switching params…
seantking Apr 11, 2022
a6342fd
feat: allow ability to lock fee module in presence of severe bug (#…
colin-axner Apr 11, 2022
aee7763
build(deps): bump actions/download-artifact from 2 to 3 (#1241)
dependabot[bot] Apr 12, 2022
8c264a8
build(deps): bump actions/upload-artifact from 2 to 3 (#1240)
dependabot[bot] Apr 12, 2022
caeb122
build(deps): bump actions/setup-go from 2 to 3 (#1242)
dependabot[bot] Apr 12, 2022
1d3c146
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.1 to 0.45.3 …
dependabot[bot] Apr 12, 2022
960a49e
chore(ics29): refund fees on distribution failure (#1245)
damiannolan Apr 12, 2022
e59a6d2
refactor: Fix RefundFeesOnChannel (#1244)
colin-axner Apr 13, 2022
f636ee3
deprecate GetTransferAccount (#1250)
Apr 13, 2022
31d5776
docs: replace links in apps with correct ones (#1255)
Apr 14, 2022
4872c4b
update godoc of `RegisterInterchainAccount` (#1256)
Apr 14, 2022
eaff98b
isolate packet fee distribution for on acknowledgement and on timeout…
colin-axner Apr 14, 2022
2120d2e
Update supported release lines (#1263)
Apr 14, 2022
63c5341
ics29: gracefully handle escrow out of balance edge case during fee d…
colin-axner Apr 14, 2022
2ab4359
build(deps): bump github.com/spf13/viper from 1.10.1 to 1.11.0 (#1264)
dependabot[bot] Apr 14, 2022
acb0e9f
chore(ics29): make EscrowPacketFee private (#1252)
damiannolan Apr 14, 2022
23fccc5
add missing changelog entry for bump of sdk 0.45.3 (#1272)
Apr 19, 2022
86638c2
feat: Add GetAppVersion to ICS4Wrapper (#1022)
colin-axner Apr 20, 2022
16921d9
make URI path for getting all incentivized packets for channel consis…
Apr 21, 2022
a187803
chore : add selected channel version to MsgChanOpenInitResponse and M…
vuong177 Apr 21, 2022
21c7744
build(deps): bump github/codeql-action from 1 to 2 (#1289)
dependabot[bot] Apr 25, 2022
2239625
build(deps): bump google.golang.org/grpc from 1.45.0 to 1.46.0 (#1290)
dependabot[bot] Apr 26, 2022
bace988
fixing dead links from sdk default branch update (#1301)
damiannolan Apr 26, 2022
9aea0fe
change fee version string to make it consistent with transfer version…
Apr 27, 2022
0a98ac6
build(deps): bump github.com/armon/go-metrics from 0.3.10 to 0.3.11 (…
dependabot[bot] Apr 28, 2022
cc4cd7b
refactor: cleanup middleware stacks (#1248)
seantking Apr 28, 2022
f2577f9
add empty keepers checking in ibc NewKeeper (#1284)
catShaark Apr 29, 2022
f962485
add query flags to command for querying counterparty address (#1313)
Apr 29, 2022
d91d1ad
add validation of packet ID in CLI to query packet (#1314)
May 2, 2022
bd08650
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.3 to 0.45.4 …
dependabot[bot] May 3, 2022
7bb609c
refactor: renaming Result in IncentivizedAcknowledgement to AppAcknow…
seantking May 4, 2022
af3d522
update mergify.yaml (#1332)
May 9, 2022
ce7ac2e
chore: renaming KeyForwardRelayerAddress to KeyRelayerAddressForAsync…
damiannolan May 10, 2022
dcd0681
refactor: channel handshake version improvements (#1283)
seantking May 10, 2022
ab8ab42
fix: emit ics29 events on cacheCtx write after refunding on closed ch…
colin-axner May 11, 2022
23e7e7d
chore: improve DenomTrace grpc (#1342)
catShaark May 12, 2022
10dc929
fix: disallow incentivizing packets which have not been sent or have …
colin-axner May 12, 2022
9f70a07
refactor: adding check if channel exists before register counterparty…
seantking May 12, 2022
5d83421
check fee module locked and enable fee before refunding all fees (#1341)
vuong177 May 16, 2022
3b31a4b
build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (#1350)
dependabot[bot] May 16, 2022
21021d0
build(deps): bump google.golang.org/grpc from 1.46.0 to 1.46.2 (#1358)
dependabot[bot] May 16, 2022
2709c24
override default docsBranch (#1355)
May 16, 2022
b7b4400
Return error if fee module is locked before distributing fees on ackn…
vuong177 May 16, 2022
2ae4f10
refactor: emit cumulative fees when incentivizing a packet multiple t…
colin-axner May 18, 2022
bf444a6
add swagger for interchain accounts (#1402)
May 23, 2022
f05a7cf
Add Sender to funginble_token_packet events
chatton May 23, 2022
c809c51
chore: Updated CHANGELOG.md
chatton May 23, 2022
d8be3d0
Update CHANGELOG.md
chatton May 23, 2022
46d73a0
Update CHANGELOG.md
chatton May 23, 2022
7e3df22
Merge pull request #1414 from chatton/issue#996-add-sender-to-fungibl…
chatton May 23, 2022
79ddb9d
chore: mini nits from ics29 audit (#1348)
seantking May 23, 2022
abd577e
fumpt (#1335)
faddat May 24, 2022
661b3d9
Update CHANGELOG.md
May 24, 2022
ba8c872
chore: Fixing github action workflows
chatton May 24, 2022
1ebaf3e
chore: Specifying build command for the CodeQL action
chatton May 24, 2022
3a53fea
Merge branch 'main' into fix-code-ql-and-check-docs-gh-actions
chatton May 24, 2022
fb28767
Merge pull request #1428 from chatton/fix-code-ql-and-check-docs-gh-a…
chatton May 24, 2022
b57e6dd
fix: cli params ordering ics29 (#1353)
seantking May 24, 2022
846306f
add swagger for fee (#1403)
May 24, 2022
374875d
add new team member to global code owners (#1404)
May 24, 2022
bd0adfb
add section for fee code owners (#1405)
May 24, 2022
1acb3cc
fix path (#1406)
May 24, 2022
25767f6
fix: ica controller middleware error typo (#1419)
hea9549 May 25, 2022
f12f841
build(deps): bump github.com/spf13/viper from 1.11.0 to 1.12.0 (#1448)
dependabot[bot] May 29, 2022
8062d01
add actual parameter example to denom-trace and denom-hash CLI querie…
May 30, 2022
373e1e6
refactor of rest urls (#1431)
May 30, 2022
899f791
Adding gRPC query for escrow address (#1416)
chatton May 30, 2022
9ed5ca4
Emit channel close event on ordered channel close (#1464)
chatton May 31, 2022
7484dbd
Fix typo (#1468)
k-yang Jun 1, 2022
b9a9502
fix typo in comment (#1435)
gnongs Jun 1, 2022
e193365
fix typo (#1434)
gnongs Jun 1, 2022
2566569
build(deps): bump github.com/armon/go-metrics from 0.3.11 to 0.4.0 (#…
dependabot[bot] Jun 2, 2022
46f5eee
build(deps): bump google.golang.org/grpc from 1.46.2 to 1.47.0 (#1481)
dependabot[bot] Jun 2, 2022
97e6b38
Add simd Dockerfile (#1485)
chatton Jun 3, 2022
fe8e456
build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (#1…
dependabot[bot] Jun 6, 2022
ba83e70
build(deps): bump goreleaser/goreleaser-action from 2 to 3 (#1415)
dependabot[bot] Jun 7, 2022
b2ca193
Emit an event to indicate a successful acknowledgement in the ICA mod…
chatton Jun 7, 2022
042d818
chore: Add consensus state heights query (#1336)
catShaark Jun 7, 2022
15a3280
feat: adding fee middleware support to ics27 interchain accounts (#1432)
damiannolan Jun 8, 2022
7999001
test: adding fee middleware tests for ics27 interchain accounts (#1433)
damiannolan Jun 8, 2022
040f2ea
feat: adding RegisterPayee rpc to ics29 fee middleware (#1491)
damiannolan Jun 8, 2022
57aa5ec
feat: adding RegisteredPayees to ics29 genesis state (#1492)
damiannolan Jun 8, 2022
187772b
fix typo
Jun 8, 2022
2c76973
feat: adding Payee grpc query and CLI (#1493)
damiannolan Jun 9, 2022
08d91ad
feat: added check for wildcard * to allow all message types (#1512)
charleenfei Jun 9, 2022
5e5e2cd
fix: deprecate AllowUpdateAfter...check (#1511)
charleenfei Jun 9, 2022
da232b8
changed gRPC web route to consensus_state/{client_id}/heights (#1517)
Jun 11, 2022
1370784
Update adr-026-ibc-client-recovery-mechanisms.md
Jun 11, 2022
11297aa
Skip distribution if refund fails to send on channel closure (#1523)
chatton Jun 13, 2022
ead32f6
Build simd images as part of the release process (#1533)
chatton Jun 14, 2022
dab07f9
refactor: rename RegisterCounterpartyAddress rpc to RegisterCounterpa…
damiannolan Jun 14, 2022
3a235af
fix to correctly parse denoms with slashes in the base denom (#1451)
Jun 14, 2022
b8b0787
build(deps): bump docker/metadata-action from 3.3.0 to 4.0.1 (#1538)
dependabot[bot] Jun 14, 2022
de49b9a
build(deps): bump docker/login-action from 1.10.0 to 2 (#1540)
dependabot[bot] Jun 14, 2022
1efe10f
build(deps): bump docker/build-push-action from 2.5.0 to 3 (#1539)
dependabot[bot] Jun 14, 2022
c04adf3
replace reflect.DeepEqual with custom comparison function because Dee…
Jun 14, 2022
2824717
docs: update ICA auth module section about RegisterInterchainAccount …
Jun 15, 2022
0252bfb
refactor: rename genesis type RegisteredRelayer to RegisteredCounterp…
damiannolan Jun 15, 2022
a71fc10
refactor: rename CounterpartyAddress query to CounterpartyPayee (#1522)
damiannolan Jun 15, 2022
223f9d2
chore: update changelog, versions for docs site and stable release ta…
Jun 15, 2022
681a558
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.4 to 0.45.5 …
dependabot[bot] Jun 15, 2022
1be4519
docs: overview of fee middleware (#1549)
charleenfei Jun 16, 2022
9680cb9
feat: implement registered payee fee distribution (#1526)
damiannolan Jun 17, 2022
6c034bc
add migration for base denoms with slashes to docs site (#1544)
Jun 20, 2022
b9f3d95
add migration of v3 to v4 to docs site (#1548)
Jun 20, 2022
44ca48d
add new release lines to dropdown menu (#1552)
Jun 20, 2022
22a51ec
build(deps): bump github.com/stretchr/testify from 1.7.2 to 1.7.3 (#1…
dependabot[bot] Jun 20, 2022
71d7480
refactor: writing test case for module account incentivizing packet (…
seantking Jun 22, 2022
dbd0f77
chore: ics29 fee payee event emission (#1568)
damiannolan Jun 23, 2022
8ffa912
chore: allow ics27 to select and return default JSON encoded metadata…
damiannolan Jun 23, 2022
5467300
docs: ics29 middleware usage for app devs (#1567)
damiannolan Jun 23, 2022
6ff5300
build(deps): bump technote-space/get-diff-action from 6.0.1 to 6.1.0 …
dependabot[bot] Jun 23, 2022
c9cd8f9
build(deps): bump github.com/spf13/cobra from 1.4.0 to 1.5.0 (#1562)
dependabot[bot] Jun 23, 2022
9dc3492
build(deps): bump github.com/stretchr/testify from 1.7.3 to 1.7.4 (#1…
dependabot[bot] Jun 23, 2022
a7d6090
docs: move ics20 docs from spec to top level docs (#1554)
Jun 23, 2022
d8130c3
fix typo in parameter name of `NewDefaultMetadata` (#1573)
Jun 23, 2022
20ffa6f
adding team members to 02-client and light-clients code owners (#1563)
Jun 23, 2022
e7d5bda
build(deps): bump github.com/stretchr/testify from 1.7.4 to 1.7.5 (#1…
dependabot[bot] Jun 26, 2022
33afe10
docs: document that version string can be empty as argument of Regist…
crodriguezvega Jun 26, 2022
b2cd6e8
Revert "docs: document that version string can be empty as argument o…
crodriguezvega Jun 26, 2022
8be6a10
docs: payee registration and fee distribution for relayer operators (…
damiannolan Jun 27, 2022
1d94aad
docs: msg types for fee middleware (#1572)
charleenfei Jun 27, 2022
3b5db68
chore: adding module name to incentivized packet events (#1580)
damiannolan Jun 27, 2022
36a3382
docs: adding events to fee middleware docs (#1578)
damiannolan Jun 27, 2022
83ca736
docs: adding End Users section to ics29 docs (#1579)
seantking Jun 27, 2022
8422d0c
feat: emitting an event when handling a client upgrade proposal (#1570)
seantking Jun 27, 2022
0479198
docs: nits (#1595)
seantking Jun 27, 2022
84792ba
docs: document that version string can be empty as argument of Regist…
Jun 27, 2022
41282c7
docs: add upgrade client proposal event (#1596)
Jun 28, 2022
b40dbc6
Consolidate usage of NewErrorAcknowledgement (#1565)
chatton Jun 28, 2022
f283d12
docs: adding line about module accounts / invariants (#1597)
seantking Jun 28, 2022
ecf3543
follow up nits to #1565 (#1598)
Jun 29, 2022
d170a41
build(deps): bump github.com/stretchr/testify from 1.7.5 to 1.8.0 (#1…
dependabot[bot] Jun 29, 2022
48a6ae5
chore: bump go package version to v4 (#1564)
Jun 29, 2022
7d971ec
deps: bumping go version 1.18 (#1627)
damiannolan Jul 1, 2022
ea64db7
add backport to v4.0.x and remove backports to v1 (EoL) (#1629)
Jul 1, 2022
6c4a442
delete unused 04-channel version functions (#1636)
Jul 1, 2022
e049649
build(deps): bump github.com/cosmos/cosmos-sdk from 0.45.5 to 0.45.6 …
dependabot[bot] Jul 4, 2022
7d18182
update mergify.yml with new release branches (#1654)
Jul 5, 2022
527a11a
Script to dynamically generate list of e2e tests (E2E #1) (#1644)
chatton Jul 6, 2022
6d1fa91
Add GitHub actions for e2e tests (E2E #2) (#1646)
chatton Jul 8, 2022
7370a8b
Remove crossings hello (#1317)
vuong177 Jul 11, 2022
c449d85
docs: update roadmap (#1678)
Jul 12, 2022
9aab42d
refactor: remove crossing hellos from 03-connection (#1672)
colin-axner Jul 12, 2022
ef4eaf9
(core/23-commitment/types) doc: fix typo (#1694)
renaynay Jul 12, 2022
1e6af48
remove spurious `TestABCICodeDeterminism` tests (#1695)
Jul 13, 2022
da45cad
update bug report issue template (#1693)
colin-axner Jul 13, 2022
b9e35eb
fix codeowners for 02-client (#1696)
Jul 13, 2022
e8dd1a8
build(deps): bump google.golang.org/grpc from 1.47.0 to 1.48.0 (#1699)
dependabot[bot] Jul 13, 2022
419c3c4
docs: update middleware documentation (#1639)
Jul 14, 2022
b0b1810
Adding github action to run goimports (#1673)
chatton Jul 14, 2022
81d10d4
Add E2ETestSuite Type (E2E #3) (#1650)
chatton Jul 14, 2022
0fd5656
Separate go mod for e2e (E2E #4) (#1701)
chatton Jul 15, 2022
c96fe92
put back module name in event (#1681)
Jul 15, 2022
95cd1c5
fix typo
Jul 18, 2022
74ed532
Extracting e2e tests into two separate workflows (#1719)
chatton Jul 18, 2022
c7be122
add categories
Jul 19, 2022
193e414
Add fee middleware test suite functions (E2E #5) (#1710)
chatton Jul 19, 2022
9776639
Build local image to run tests with make e2e-test (#1722)
chatton Jul 19, 2022
c809ce3
Remove leftover crossing hello tests in connection handshake (#1724)
AdityaSripal Jul 19, 2022
5b61a5b
chore: adding environment variable to specify go relayer image (#1727)
chatton Jul 19, 2022
d1649c0
Thomas/1584 update docs apps (#1675)
tmsdkeys Jul 19, 2022
aaccbd1
update fee mw docs, add formating, fix typos, increase readability (#…
tmsdkeys Jul 19, 2022
bdd797e
chore: remove @fedekunze from CODEOWNERS (#1733)
fedekunze Jul 20, 2022
8987888
Test for AsyncSingleSender (E2E #6) (#1682)
chatton Jul 20, 2022
cc74109
fix: running e2e-fork for dependabot PRs (#1745)
chatton Jul 20, 2022
5f5a287
Adding manual triggering of e2e via workflow dispatch (#1749)
chatton Jul 21, 2022
be5ccf3
chore: denom traces migration handler (#1680)
charleenfei Jul 21, 2022
049d336
add changelog entry for #1680
Jul 21, 2022
0caf625
add issue templates for epics and releases (#1702)
Jul 21, 2022
c1a727e
fix typo
Jul 21, 2022
3af515d
fix typo
Jul 21, 2022
c12789d
feat: allow governance to update the TrustingPeriod of the 07-tenderm…
charleenfei Jul 21, 2022
7dc9fed
E2E Test: TestMsgPayPacketFeeSingleSender (#1756)
chatton Jul 21, 2022
ebc7638
move entry to right place
Jul 22, 2022
141b223
build(deps): bump docker/build-push-action from 3.0.0 to 3.1.0 (#1743)
dependabot[bot] Jul 25, 2022
492e14d
chore: Update makefile (#1770)
colin-axner Jul 25, 2022
32531e7
add version matrix (#1767)
Jul 26, 2022
fb19126
add pseudocode to handle empty version string in OnChanOpenInit
Jul 26, 2022
ef7a5c7
fix broken link (#1776)
Jul 26, 2022
85893ee
add item to update the version matrix after a release (#1775)
Jul 26, 2022
214e4a3
E2E Test: TestMsgPayPacketFeeSingleSenderTimesOut (#1751)
chatton Jul 27, 2022
547da7b
Move scripts from .github directory into cmd (#1787)
chatton Jul 27, 2022
8493d3c
Update Makefile (#1785)
faddat Jul 27, 2022
126ab2d
fix: change non nil relayer check to non empty (#1774)
colin-axner Jul 27, 2022
af4e651
chore: v4->v5 only (#1782)
faddat Jul 27, 2022
48c456d
gofumpt to reduce total number of changes versus v5 (#1734)
faddat Jul 27, 2022
79cd69f
Update release-tracker.md
Jul 27, 2022
031f6a3
🧹 Linting (#1418)
faddat Jul 28, 2022
40d0ff7
fix: add cosmos_proto.implements_interface (#1740)
pyramation Jul 28, 2022
045ab6f
docs: adding README.md for how to write e2e tests (#1769)
chatton Jul 28, 2022
029e428
chore: remove refs to AllowUpdateToExpired/Frozen client booleans (#1…
charleenfei Jul 28, 2022
88e4388
Revert "chore: remove refs to AllowUpdateToExpired/Frozen client bool…
charleenfei Jul 28, 2022
4a781e5
fix: assert previous channel identifer is empty in Msg ValidateBasic …
colin-axner Jul 28, 2022
faea729
chore: rename decorator to `RedundancyRelayDecorator` (#1820)
Jul 28, 2022
0be6c42
fix: assert previous connection id to be empty (#1797)
colin-axner Jul 28, 2022
6b4aa9a
build(deps): bump google.golang.org/protobuf from 1.28.0 to 1.28.1 (#…
dependabot[bot] Jul 29, 2022
0410963
ibc-go v5: cosmos-sdk 46 (#1653)
faddat Aug 1, 2022
42bc9ce
chore: add backport task for v5.0.x (#1840)
Aug 1, 2022
624c5f7
chore: delete gitpod.yml (#1841)
Aug 1, 2022
8d14cba
build(deps): bump cosmossdk.io/math from 1.0.0-beta.2 to 1.0.0-beta.3…
dependabot[bot] Aug 2, 2022
4f817bd
Update RELEASES.md
Aug 2, 2022
5969304
fix: proto-update-deps target on macOS (#1838)
nicopernas Aug 2, 2022
7237c43
bump version from 3 to 5
colin-axner Aug 2, 2022
6cdcc63
merge main
colin-axner Aug 2, 2022
0d8f408
fix merge conflicts
colin-axner Aug 2, 2022
a7d23fd
fix build
colin-axner Aug 3, 2022
f861e0e
go imports
colin-axner Aug 3, 2022
607458a
make format
colin-axner Aug 3, 2022
e9a7fac
fix linter
colin-axner Aug 3, 2022
18eee1a
apply review suggestions
colin-axner Aug 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: document that version string can be empty as argument of Regist…
…erInterchainAccount
  • Loading branch information
crodriguezvega committed Jun 26, 2022
commit 33afe107b77417bfb75c0fcb0fc4667f0d9bdcc6
6 changes: 3 additions & 3 deletions docs/apps/interchain-accounts/active-channels.md
Original file line number Diff line number Diff line change
@@ -12,11 +12,11 @@ channel type that provides ordering of packets without the channel closing on ti
When an Interchain Account is registered using the `RegisterInterchainAccount` API, a new channel is created on a particular port. During the `OnChanOpenAck` and `OnChanOpenConfirm` steps (controller & host chain) the `Active Channel` for this interchain account
is stored in state.

It is possible to create a new channel using the same controller chain portID if the previously set `Active Channel` is now in a `CLOSED` state. This channel creation can be initialized programatically by sending a new `OnChanOpenInit` message like so:
It is possible to create a new channel using the same controller chain portID if the previously set `Active Channel` is now in a `CLOSED` state. This channel creation can be initialized programatically by sending a new `MsgChannelOpenInit` message like so:

```go
msg := channeltypes.NewMsgChannelOpenInit(portID, string(versionBytes), channeltypes.ORDERED, []string{connectionID}, icatypes.PortID, icatypes.ModuleName)
handler := k.msgRouter.Handler(msg)
msg := channeltypes.NewMsgChannelOpenInit(portID, string(versionBytes), channeltypes.ORDERED, []string{connectionID}, icatypes.PortID, icatypes.ModuleName)
handler := k.msgRouter.Handler(msg)
```

Alternatively, any relayer operator may initiate a new channel handshake for this interchain account once the previously set `Active Channel` is in a `CLOSED` state. This is done by initiating the channel handshake on the controller chain using the same portID associated with the interchain account in question.
8 changes: 4 additions & 4 deletions docs/apps/interchain-accounts/auth-modules.md
Original file line number Diff line number Diff line change
@@ -38,15 +38,15 @@ func (im IBCModule) OnChanOpenInit(
chanCap *capabilitytypes.Capability,
counterparty channeltypes.Counterparty,
version string,
) error {
) (string, error) {
// the authentication module *must* claim the channel capability on OnChanOpenInit
if err := im.keeper.ClaimCapability(ctx, chanCap, host.ChannelCapabilityPath(portID, channelID)); err != nil {
return err
return version, err
}

// perform custom logic

return nil
return version, nil
}

// OnChanOpenAck implements the IBCModule interface
@@ -157,7 +157,7 @@ if err := keeper.icaControllerKeeper.RegisterInterchainAccount(ctx, connectionID
return nil
```

The `version` argument is used to support ICS29 fee middleware for relayer incentivization of ICS27 packets. Consumers of the `RegisterInterchainAccount` are expected to build the appropriate JSON encoded version string themselves and pass it accordingly.
The `version` argument is used to support ICS29 fee middleware for relayer incentivization of ICS27 packets. Consumers of the `RegisterInterchainAccount` are expected to build the appropriate JSON encoded version string themselves and pass it accordingly. If an empty string is passed in the `version` argument, then the version will be initialized to a default value in the `OnChanOpenInit` callback of the controller's handler, so that channel handshake can proceed.

The following code snippet illustrates how to construct an appropriate interchain accounts `Metadata` and encode it as a JSON bytestring:

2 changes: 1 addition & 1 deletion docs/migrations/v3-to-v4.md
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ The return signature now includes the application version as detailed in the lat

The `RegisterInterchainAccount` API has been modified to include an additional `version` argument. This change has been made in order to support ICS29 fee middleware, for relayer incentivization of ICS27 packets.
Consumers of the `RegisterInterchainAccount` are now expected to build the appropriate JSON encoded version string themselves and pass it accordingly.
This should be constructed within the interchain accounts authentication module which leverages the APIs exposed via the interchain accounts `controllerKeeper`.
This should be constructed within the interchain accounts authentication module which leverages the APIs exposed via the interchain accounts `controllerKeeper`. If an empty string is passed in the `version` argument, then the version will be initialized to a default value in the `OnChanOpenInit` callback of the controller's handler, so that channel handshake can proceed.

The following code snippet illustrates how to construct an appropriate interchain accounts `Metadata` and encode it as a JSON bytestring: