fix: complete changes for CheckSubstituteAndUpdateState #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
seantking and
damiannolan
as code owners
colin-axner
commented
Aug 4, 2022
| ctx.EventManager().EmitEvent( | ||
| sdk.NewEvent( | ||
| types.EventTypeUpdateClientProposal, | ||
| sdk.NewAttribute(types.AttributeKeySubjectClientID, clientID), | ||
| sdk.NewAttribute(types.AttributeKeyClientType, clientState.ClientType()), | ||
| sdk.NewAttribute(types.AttributeKeyConsensusHeight, clientState.GetLatestHeight().String()), |
There was a problem hiding this comment.
There's no way to guarantee the latest height of the substitute is the latest height of subject. I question the usefulness of this information, so I'd prefer to remove it for now until it is requested (at which time we can query the subject client state)
colin-axner
commented
Aug 4, 2022
colin-axner
commented
Aug 4, 2022
|
|
||
| defer func() { | ||
| telemetry.IncrCounterWithLabels( | ||
| []string{"ibc", "client", "update"}, | ||
| 1, | ||
| []metrics.Label{ | ||
| telemetry.NewLabel(types.LabelClientType, clientState.ClientType()), | ||
| telemetry.NewLabel(types.LabelClientType, substituteClientState.ClientType()), |
There was a problem hiding this comment.
cannot guarantee client type doesn't change for the subject, so we use the substitute client type
colin-axner
commented
Aug 4, 2022
| CheckSubstituteAndUpdateState(ctx sdk.Context, cdc codec.BinaryCodec, subjectClientStore, substituteClientStore sdk.KVStore, substituteClient ClientState) (ClientState, error) | ||
| // CheckSubstituteAndUpdateState must verify that the provided substitute may be used to update the subject client. | ||
| // The light client must set the updated client and consensus states within the clientStore for the subject client. | ||
| CheckSubstituteAndUpdateState(ctx sdk.Context, cdc codec.BinaryCodec, subjectClientStore, substituteClientStore sdk.KVStore, substituteClient ClientState) error |
There was a problem hiding this comment.
I realized we (I) forgot to update the interface for this function
seantking
approved these changes
Aug 4, 2022
…c-go into colin/fix-substitute-interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes