chore: adapt ics27 controller claiming of channel capability #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
seantking,
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
|
Please let me know if there's any additional tests to add. I'll update with a changelog entry also 👍 |
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 79.28% 79.24% -0.04%
==========================================
Files 170 170
Lines 11855 11862 +7
==========================================
+ Hits 9399 9400 +1
- Misses 2040 2044 +4
- Partials 416 418 +2
|
seantking
approved these changes
Aug 30, 2022
AdityaSripal
approved these changes
Aug 30, 2022
colin-axner
approved these changes
Aug 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
* [WIP] adding current code, test failures due to removal of claim capaiblities in mock IBCApp * [WIP] removing changes to fee tests * [WIP] removing whitespaces * adding nil check on chan caps in mock ibc module * adding changelog entry Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 56f9da2) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go
damiannolan
added a commit
that referenced
this pull request
Aug 31, 2022
…#2146) (#2150) * chore: adapt ics27 controller claiming of channel capability (#2146) * [WIP] adding current code, test failures due to removal of claim capaiblities in mock IBCApp * [WIP] removing changes to fee tests * [WIP] removing whitespaces * adding nil check on chan caps in mock ibc module * adding changelog entry Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 56f9da2) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go * resolving conflicts * Update CHANGELOG.md Co-authored-by: Damian Nolan <damiannolan@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nilSendTxis now ignored and looked up internallytesting/mockIBCModule now only claims the channel capability if it is notnilcloses: #2033
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes