Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding x/group to simapp #2190

Merged
merged 7 commits into from
Sep 8, 2022
Merged

chore: adding x/group to simapp #2190

merged 7 commits into from
Sep 8, 2022

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Sep 5, 2022 •
edited
Loading

Description

  • Adds x/group module to simapp

needed for: #2039

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan damiannolan marked this pull request as ready for review September 6, 2022 07:16
colin-axner
colin-axner approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye! Nice! Could you add a changelog entry :)

chatton
chatton approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@damiannolan damiannolan enabled auto-merge (squash) September 8, 2022 10:12
@damiannolan damiannolan merged commit ec0a11c into main Sep 8, 2022
@damiannolan damiannolan deleted the damian/add-x-group-to-simd branch September 8, 2022 14:32
@mergify mergify bot mentioned this pull request Sep 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
@damiannolan @mergify
chore: adding x/group to simapp (#2190)
8a4d6a5 
* adding x/group to simapp

* adding changelog entry

(cherry picked from commit ec0a11c)
colin-axner pushed a commit that referenced this pull request Sep 8, 2022
@mergify @damiannolan
chore: adding x/group to simapp (#2190) (#2238)
550c692 
* adding x/group to simapp

* adding changelog entry

(cherry picked from commit ec0a11c)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
@chatton chatton mentioned this pull request Nov 7, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@chatton chatton chatton approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damiannolan @chatton @colin-axner @crodriguezvega