Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding msgServer struct to ics27 controller #2251

Merged
merged 1 commit into from
Sep 9, 2022
Merged

chore: adding msgServer struct to ics27 controller #2251

merged 1 commit into from
Sep 9, 2022

Conversation

damiannolan
Copy link
Member

Description

  • Adding msgServer struct to ics27 controller submodule

closes: #2229

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan damiannolan marked this pull request as ready for review September 9, 2022 09:09
@codecov-commenter
Copy link

Codecov Report

Merging #2251 (44bbb39) into main (b601462) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2251   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         175      175           
  Lines       12067    12069    +2     
=======================================
+ Hits         9596     9598    +2     
  Misses       2047     2047           
  Partials      424      424
Impacted Files Coverage Δ
...nterchain-accounts/controller/keeper/msg_server.go 91.66% <100.00%> (+0.49%) ⬆️
modules/apps/27-interchain-accounts/module.go 50.51% <100.00%> (ø)

chatton
chatton approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job 👍

charleenfei
charleenfei approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@damiannolan damiannolan enabled auto-merge (squash) September 9, 2022 09:50
@damiannolan damiannolan merged commit da1b7e0 into main Sep 9, 2022
@damiannolan damiannolan deleted the damian/2229-add-msg-server-struct branch September 9, 2022 09:51
mergify bot pushed a commit that referenced this pull request Sep 9, 2022
@damiannolan @mergify
chore: adding msgServer struct to ics27 controller (#2251)
5e1c185 
(cherry picked from commit da1b7e0)
@mergify mergify bot mentioned this pull request Sep 9, 2022
Merged
crodriguezvega
crodriguezvega reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see that this is already merged, but I left just a nit...

modules/apps/27-interchain-accounts/controller/keeper/msg_server.go

// RegisterAccount defines a rpc handler for MsgRegisterAccount
func (k Keeper) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) {
func (k msgServer) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should k be ms instead?

This was referenced Sep 9, 2022
Merged
Merged
colin-axner pushed a commit that referenced this pull request Sep 12, 2022
@mergify @damiannolan @crodriguezvega
chore: adding msgServer struct to ics27 controller (#2251) (#2254)
9d0c6d2 
(cherry picked from commit da1b7e0)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@chatton chatton mentioned this pull request Nov 7, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega left review comments

@chatton chatton chatton approved these changes

@charleenfei charleenfei charleenfei approved these changes

@seantking seantking Awaiting requested review from seantking

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a message server struct to ics27 controller
5 participants
@damiannolan @codecov-commenter @crodriguezvega @chatton @charleenfei