-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix #2450
Merged
crodriguezvega
merged 6 commits into
cosmos:main
from
alizahidraja:ali/chore-rename-icatypes-post-prefix
Oct 4, 2022
Merged
Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix #2450
crodriguezvega
merged 6 commits into
cosmos:main
from
alizahidraja:ali/chore-rename-icatypes-post-prefix
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es.PortID to icatypes.HostPortID
alizahidraja
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner and
damiannolan
as code owners
September 30, 2022 15:10
alizahidraja
requested review from
crodriguezvega and
chatton
as code owners
September 30, 2022 15:13
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
=======================================
Coverage 78.64% 78.64%
=======================================
Files 178 178
Lines 12365 12365
=======================================
Hits 9725 9725
Misses 2208 2208
Partials 432 432
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @alizahidraja!
crodriguezvega
approved these changes
Oct 3, 2022
colin-axner
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ay! Thanks @alizahidraja
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
* renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID * updated changelog.md * updated changelog.md (cherry picked from commit 2056c2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID
closes: #2433
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
) (not applicable)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes