Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump SDK v0.46.7 in v6.1.x #2945

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Dec 15, 2022

Description

ref: #2929

Commit Message / Changelog Entry

deps: bump SDK v0.46.7 

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crodriguezvega! I think we also need to update main, right?

@crodriguezvega
Copy link
Contributor Author

crodriguezvega commented Dec 16, 2022

Thanks @crodriguezvega! I think we also need to update main, right?

I was thinking of skipping main since hopefully we will be able to merge the PR with v0.47-alpha2 soon. Do you think it would be worth doing anyway?

@damiannolan
Copy link
Member

Thanks @crodriguezvega! I think we also need to update main, right?

I was thinking of skipping main since hopefully we will be able to merge the PR with v0.47-alpha2 soon. Do you think it would be worth doing anyway?

Good point! Happy to go with that if you are!

@crodriguezvega crodriguezvega merged commit 501d904 into release/v6.1.x Dec 16, 2022
@crodriguezvega crodriguezvega deleted the carlos/v6.1.x-bump-SDK branch December 16, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants