Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting for packages #3198

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix linting for packages #3198

merged 1 commit into from
Feb 23, 2023

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Feb 23, 2023

Description

There was an issue where when linting a single file, types defined in other files do not resolve correctly and linting fails. This PR makes the script lint the directory the file is in (the go package) so all types are resolved correctly.

closes: N/A

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@chatton chatton marked this pull request as ready for review February 23, 2023 15:59
@chatton chatton merged commit 25e2c45 into main Feb 23, 2023
@chatton chatton deleted the cian/fix-linting-packages branch February 23, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants