ICA: Adding tests for relay.go

[seantking]

Description

Adding tests for relay.go

• TrySendTx
• DeserializeTx
• AuthenticateTx
• OnRecvPacket
• OnAcknowledgementPacket
• OnTimeoutPacket

partially closes: #279

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[seantking]

random fix

[colin-axner]

Nice work!! Left several nits

[colin-axner]

Want to add a helper function:

func SetupICAPath(path *ibctesting.Path, owner string) error {
	if err := InitInterchainAccount(path.EndpointA, owner); err != nil {
		return err
	}

	if err := path.EndpointB.ChanOpenTry(); err != nil {
		return err
	}

	if err := path.EndpointA.ChanOpenAck(); err != nil {
		return err
	}

	if err := path.EndpointA.ChanOpenConfirm(); err != nil {
		return err
	}

	return nil
}

[seantking]

https://github.com/cosmos/ibc-go/pull/337/files#r706278394

[seantking]

path.EndpointA.ChanOpenConfirm() didn't seem to work here for me. I needed to use simApp

[colin-axner]

path.EndpointA.ChanOpenConfirm() didn't seem to work here for me. I needed to use simApp

It was a bug on my part (and a good sign it didn't work). It should be:

path.EndpointB.ChanOpenConfirm()

not

path.EndpointA.ChanOpenConfirm()

A -> B

Would be good to switch back since you are using the Keeper on chainB and the context on chainA

[seantking]

@colin-axner wdyt about having follow-up PRs for remaining relay.go tests?

[colin-axner]

@colin-axner wdyt about having follow-up PRs for remaining relay.go tests?

heavy +1. I'm all about many short pr's as opposed to one large one

[colin-axner]

path.EndpointA.ChanOpenConfirm() didn't seem to work here for me. I needed to use simApp

It was a bug on my part (and a good sign it didn't work). It should be:

path.EndpointB.ChanOpenConfirm()

not

path.EndpointA.ChanOpenConfirm()

A -> B

Would be good to switch back since you are using the Keeper on chainB and the context on chainA

[colin-axner]

this could probably be a var defined at the top of the test? (reduce code)