Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

07-tendermint: add missing interface check for ConsensusState #3437

Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Apr 12, 2023

Description

closes: #XXXX

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I see there's two conflicting styles for this, one using a nil pointer and the other using the address of an empty struct. Though both can be used, I'd guess a nil pointer is slightly more efficient since it doesn't require default initialization for any potential struct members.

Should we open an issue to have all these use the same form of assertion?

@crodriguezvega
Copy link
Contributor Author

I see there's two conflicting styles for this, one using a nil pointer and the other using the address of an empty struct.

Yes, indeed; you're right!

Should we open an issue to have all these use the same form of assertion?

Sounds good to me. I would also be fine opening directly a PR. :)

@crodriguezvega crodriguezvega merged commit 2632ae2 into main Apr 12, 2023
@crodriguezvega crodriguezvega deleted the carlos/add-missing-interface-check-consensus-state branch April 12, 2023 09:43
@DimitrisJim
Copy link
Contributor

I would also be fine opening directly a PR. :)

Will do, sharpening my greping regex-fu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants