code hygiene: add missing nil check and corresponding tests for query handlers
#3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3462 +/- ##
==========================================
+ Coverage 78.54% 78.76% +0.21%
==========================================
Files 181 181
Lines 12581 12586 +5
==========================================
+ Hits 9882 9913 +31
+ Misses 2265 2248 -17
+ Partials 434 425 -9
|
DimitrisJim
reviewed
Apr 16, 2023
modules/apps/27-interchain-accounts/controller/keeper/msg_server.go
Outdated
Show resolved
Hide resolved
crodriguezvega
commented
Apr 16, 2023
| @@ -131,6 +131,7 @@ func (k Keeper) ConnectionOpenTry(goCtx context.Context, msg *connectiontypes.Ms | |||
| // ConnectionOpenAck defines a rpc handler method for MsgConnectionOpenAck. | |||
| func (k Keeper) ConnectionOpenAck(goCtx context.Context, msg *connectiontypes.MsgConnectionOpenAck) (*connectiontypes.MsgConnectionOpenAckResponse, error) { | |||
| ctx := sdk.UnwrapSDKContext(goCtx) | |||
|
|
|||
There was a problem hiding this comment.
This extra space makes it consistent with the rest of message handlers in this file. :)
crodriguezvega
changed the title
nil check in gprc handlersnil check and corresponding tests in query handlers
crodriguezvega
changed the title
nil check and corresponding tests in query handlersnil check and corresponding tests for query handlers
damiannolan
approved these changes
Apr 17, 2023
colin-axner
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.