feat(ica/controller)!: migrate ica/controller parameters to be self managed #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal-kanna
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
changed the title
vishal-kanna
requested review from
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
|
Hey @vishal-kanna! Thanks for getting this started! There has been many comments on #3520 which could be useful to align the work in this PR. Let us know if you'd like to continue working on this, alternatively we could have someone pick up the remaining work and bring it over the finish line! |
|
Thanks for the work @vishal-kanna. I will take over the remaining work now. |
3 tasks
colin-axner
reviewed
Jun 1, 2023
modules/apps/27-interchain-accounts/controller/keeper/keeper.go
Outdated
Show resolved
Hide resolved
damiannolan
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Awesome, thank you @vishal-kanna and @srdtrk :)
One last thing would be logging msgs for both cases - successful migration and if keeper is nil and migrations are skipped. But I'm happy if they are handled as part of #3776
|
I will merge this after your approval @DimitrisJim |
DimitrisJim
reviewed
Jun 14, 2023
DimitrisJim
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR:
ica/controllersubmodule now self-manages its parameters.ica/controllersubmodule's parameters.x/params' subspace to theica/controllersubmodule's keeper.closes: #3503
addresses: #2010
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.