Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(statemachine)!: update error returned in 04-channel SendPacket #3593

Merged
merged 2 commits into from
May 17, 2023
Merged

fix(statemachine)!: update error returned in 04-channel SendPacket #3593

merged 2 commits into from
May 17, 2023

Conversation

damiannolan
Copy link
Member

Description

ref: #3568

Commit Message / Changelog Entry

fix(statemachine)!: 04-channel SendPacket now correctly returns `ErrClientNotFound` in favour of `ErrConsensusStateNotFound`

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan mentioned this pull request May 16, 2023
Merged
9 tasks
@damiannolan damiannolan marked this pull request as ready for review May 16, 2023 14:26
crodriguezvega
crodriguezvega approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @damiannolan!

@damiannolan damiannolan enabled auto-merge (squash) May 17, 2023 10:01
@damiannolan damiannolan merged commit 1f323ce into main May 17, 2023
@damiannolan damiannolan deleted the damian/3568-update-client-error branch May 17, 2023 10:07
mergify bot pushed a commit that referenced this pull request May 17, 2023
@damiannolan @mergify
fix(statemachine)!: 04-channel SendPacket now correctly returns `ErrC…
89c77c0 
…lientNotFound` in favour of `ErrConsensusStateNotFound` (#3593)

(cherry picked from commit 1f323ce)
@mergify mergify bot mentioned this pull request May 17, 2023
Merged
damiannolan added a commit that referenced this pull request May 17, 2023
@mergify @damiannolan
fix(statemachine)!: 04-channel SendPacket now correctly returns `ErrC…
3a593b2 
…lientNotFound` in favour of `ErrConsensusStateNotFound` (#3593) (#3598)

(cherry picked from commit 1f323ce)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
@faddat faddat mentioned this pull request Jun 23, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@charleenfei charleenfei charleenfei approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damiannolan @crodriguezvega @DimitrisJim @charleenfei @colin-axner