Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC Router Middleware #373

Closed
wants to merge 7 commits into from
Closed

IBC Router Middleware #373

wants to merge 7 commits into from

Conversation

jackzampolin
Copy link
Member

No description provided.

AdityaSripal
AdityaSripal requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

The receive logic in the routing case can be a lot cleaner if you call into the underlying transfer module and just do your own custom logic on top of it.

Acknowledgment and Timeout need to be fixed on the routing case

modules/apps/router/module.go Show resolved Hide resolved
modules/apps/router/module.go Show resolved Hide resolved
modules/apps/router/module.go Outdated Show resolved Hide resolved
modules/apps/router/module.go Outdated Show resolved Hide resolved
modules/apps/router/module.go Show resolved Hide resolved
modules/apps/router/module.go Show resolved Hide resolved
modules/apps/router/module.go Outdated Show resolved Hide resolved
modules/apps/router/keeper/keeper.go Outdated Show resolved Hide resolved
@ebuchman
Copy link
Member

ebuchman commented Sep 9, 2021

Is there an ICS for this or docs/spec or a relevant issue? Could we get some text description in the opening comment please?

@jackzampolin jackzampolin deleted the jack/packet-forward-middleware branch September 15, 2021 16:09
@alexanderbez
Copy link
Contributor

This PR is referenced in the official on-chain governance proposal. It's not clear why this PR was closed. Can we comment what this was replaced with and why?

@crodriguezvega
Copy link
Contributor

Being a specialized solution to enable packet routing in the Hub in the short-term (as opposed to a generic, ICS-backed multi-hop solution), we decided that ibc-go was not the most appropriate home for this middleware, so the implementation now lives in a Strangelove's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal requested changes

@charleenfei charleenfei Awaiting requested review from charleenfei

@colin-axner colin-axner Awaiting requested review from colin-axner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@seantking seantking Awaiting requested review from seantking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackzampolin @ebuchman @alexanderbez @crodriguezvega @AdityaSripal